github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

Typescript - client updateUser should throw typescript error on attempting to update an additionalFields marked as input: false #305

New Issue
Closed
opened 2026-03-13 07:41:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 07:41:20 -05:00
Owner
Copy Link

Originally created by @arfath-linklet on GitHub (Dec 1, 2024).

Describe the bug
Consider a config with additionalField:

user: {
    additionalFields: {
      role: {
        type: "string",
        required: false,
        input: false, // don't allow user to set role
      }
    },
  }

on the client attempt to updateUser

client.updateUser({ role: 'admin' })

No typescript error is thrown. Server correctly ignores the field but should it throw a validation error? Server to have strict input checking on all APIs?

Expected behavior
updateUser should accept only client updates with input: true. Additionally API could throw validation errors as additional safety check.

Originally created by @arfath-linklet on GitHub (Dec 1, 2024). **Describe the bug** Consider a config with additionalField: ``` user: { additionalFields: { role: { type: "string", required: false, input: false, // don't allow user to set role } }, } ``` on the client attempt to updateUser ``` client.updateUser({ role: 'admin' }) ``` No typescript error is thrown. Server correctly ignores the field but should it throw a validation error? Server to have strict input checking on all APIs? **Expected behavior** `updateUser` should accept only client updates with input: true. Additionally API could throw validation errors as additional safety check.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#305
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?