github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-30 10:56:31 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3366] [MERGED] Update hono.mdx sessionToken attributes param #30387

New Issue
Closed
opened 2026-04-17 21:30:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 21:30:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3366
Author: @ahmadaccino
Created: 7/14/2025
Status: ✅ Merged
Merged: 7/14/2025
Merged by: @Bekacru

Base: main ← Head: patch-1

📝 Commits (1)

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 docs/content/docs/integrations/hono.mdx (+5 -3)

📄 Description

i get this once i follow the sessionToken param according to the hono docs:

Object literal may only specify known properties, and 'sameSite' does not exist in type '{ name?: string | undefined; attributes?: CookieOptions | undefined; }'. (ts 2353)

before:
image

after:
image

System: Ubuntu/Linux
Package version: ^1.2.12

Summary by cubic

Fixed the sessionToken example in hono.mdx to place cookie attributes inside the correct attributes object, matching the expected type and preventing TypeScript errors.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3366 **Author:** [@ahmadaccino](https://github.com/ahmadaccino) **Created:** 7/14/2025 **Status:** ✅ Merged **Merged:** 7/14/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`e44e810`](https://github.com/better-auth/better-auth/commit/e44e81085e5dac94dd493dda7cd5bd6ee4687255) Update hono.mdx ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/integrations/hono.mdx` (+5 -3) </details> ### 📄 Description i get this once i follow the sessionToken param according to the hono docs: ```bash Object literal may only specify known properties, and 'sameSite' does not exist in type '{ name?: string | undefined; attributes?: CookieOptions | undefined; }'. (ts 2353) ``` before: <img width="1563" height="592" alt="image" src="https://github.com/user-attachments/assets/2e3cc296-fc10-49e2-9a31-5e486f23793c" /> after: <img width="1563" height="592" alt="image" src="https://github.com/user-attachments/assets/4a50ea8c-f82b-470a-a8a8-f7349df04e00" /> System: Ubuntu/Linux Package version: ^1.2.12 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixed the sessionToken example in hono.mdx to place cookie attributes inside the correct attributes object, matching the expected type and preventing TypeScript errors. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 21:30:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#30387
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?