github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #3343] [MERGED] fix(sso): saml redirection #30371

New Issue
Closed
opened 2026-04-17 21:29:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 21:29:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/3343
Author: @Kinfe123
Created: 7/11/2025
Status: ✅ Merged
Merged: 7/18/2025
Merged by: @Bekacru

Base: v1.3 ← Head: fix/saml-redirection

📝 Commits (10+)

📊 Changes

2 files changed (+70 additions, -71 deletions)

View changed files

📝 packages/sso/src/index.ts (+6 -3)
📝 packages/sso/src/saml.test.ts (+64 -68)

📄 Description

Summary by cubic

Fixed SAML redirection to use HTTP redirects instead of returning a JSON response, ensuring proper client navigation after SSO login.

  • Bug Fixes
    • Updated SAML callback to throw an HTTP redirect.
    • Improved SAML test to check for correct redirect behavior.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/3343 **Author:** [@Kinfe123](https://github.com/Kinfe123) **Created:** 7/11/2025 **Status:** ✅ Merged **Merged:** 7/18/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `v1.3` ← **Head:** `fix/saml-redirection` --- ### 📝 Commits (10+) - [`e522834`](https://github.com/better-auth/better-auth/commit/e5228340603f5f87971ca4e005f5baedcdda145a) saml redirection - [`6ed6c37`](https://github.com/better-auth/better-auth/commit/6ed6c3777345ae16e0e3eb71f0abaad7d3d5ee13) loh - [`a073ed9`](https://github.com/better-auth/better-auth/commit/a073ed909c54ac19e1d63ceccf8d928c747c39b5) lint - [`d094d3f`](https://github.com/better-auth/better-auth/commit/d094d3f9420cb5d554fe6a6b8a89c067e91b69be) dashboard - [`7af0790`](https://github.com/better-auth/better-auth/commit/7af0790e11f53e2cb0048f6a929206a081376d8b) lint - [`a031b73`](https://github.com/better-auth/better-auth/commit/a031b7354111cfd7766762f2322820345d130b0f) test - [`ec052af`](https://github.com/better-auth/better-auth/commit/ec052af067771ebffdff12a359af9a7317ead57f) test - [`c94354a`](https://github.com/better-auth/better-auth/commit/c94354a19cc434945601204a00e219ad8d650625) function based mock idp - [`a4c883f`](https://github.com/better-auth/better-auth/commit/a4c883f6b8a791a19531c5f322d8c5ee1e3b2710) redirection and callbacks - [`bf82ea0`](https://github.com/better-auth/better-auth/commit/bf82ea003bb782da07b9da2e444bef0e215c7ca1) console ### 📊 Changes **2 files changed** (+70 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `packages/sso/src/index.ts` (+6 -3) 📝 `packages/sso/src/saml.test.ts` (+64 -68) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Fixed SAML redirection to use HTTP redirects instead of returning a JSON response, ensuring proper client navigation after SSO login. - **Bug Fixes** - Updated SAML callback to throw an HTTP redirect. - Improved SAML test to check for correct redirect behavior. <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 21:29:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#30371
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?