github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #2763] [CLOSED] fix(oidc-provider): remove need for client secret in authorization_code flows #30074

New Issue
Closed
opened 2026-04-17 21:15:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 21:15:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/2763
Author: @ieedan
Created: 5/23/2025
Status: ❌ Closed

Base: main ← Head: oidc-patch

📝 Commits (5)

  • 26dbed0 remove need for client secret in authorization_code flows
  • 006eb94 fix error message
  • 7e8a489 Merge branch 'main' into oidc-patch
  • 8450585 Merge branch 'main' into oidc-patch
  • c18d33d Merge branch 'main' into oidc-patch

📊 Changes

1 file changed (+2 additions, -10 deletions)

View changed files

📝 packages/better-auth/src/plugins/oidc-provider/index.ts (+2 -10)

📄 Description

Fixes #2655

In authorization_code flows the client_secret should not be required because it wouldn't be a secret anyways. This PR removes the need for a client_secret when calling the /token endpoint in oidc flows.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/2763 **Author:** [@ieedan](https://github.com/ieedan) **Created:** 5/23/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `oidc-patch` --- ### 📝 Commits (5) - [`26dbed0`](https://github.com/better-auth/better-auth/commit/26dbed00dbe6ebe51be432795d4c4728747af825) remove need for client secret in `authorization_code` flows - [`006eb94`](https://github.com/better-auth/better-auth/commit/006eb945936eb2fd83d3f99961228a58c14c9f41) fix error message - [`7e8a489`](https://github.com/better-auth/better-auth/commit/7e8a489ec3d77732e48667d067a6dd92706ce209) Merge branch 'main' into oidc-patch - [`8450585`](https://github.com/better-auth/better-auth/commit/8450585d68ded94a793fae98d11f333ef5ab081e) Merge branch 'main' into oidc-patch - [`c18d33d`](https://github.com/better-auth/better-auth/commit/c18d33daf18ecb85ca1d609971ce33754694c0e0) Merge branch 'main' into oidc-patch ### 📊 Changes **1 file changed** (+2 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/oidc-provider/index.ts` (+2 -10) </details> ### 📄 Description Fixes #2655 In `authorization_code` flows the `client_secret` should not be required because it wouldn't be a secret anyways. This PR removes the need for a `client_secret` when calling the `/token` endpoint in oidc flows. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 21:15:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#30074
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?