github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-30 19:06:47 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #2423] [MERGED] add: tests for create-adapter to not include an id when generate id is disabled #29912

New Issue
Closed
opened 2026-04-17 21:09:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 21:09:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/2423
Author: @ping-maxwell
Created: 4/24/2025
Status: ✅ Merged
Merged: 6/28/2025
Merged by: @Bekacru

Base: main ← Head: tests/create-adapter/dont-gen-id

📝 Commits (2)

  • e2712ad add: tests for create-adapter to not include an id when generate id is disabled
  • a147628 chore: minor improvements

📊 Changes

1 file changed (+25 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/adapters/create-adapter/test/create-adapter.test.ts (+25 -0)

📄 Description

Nothing is broken as of now, just adding another test to prevent future bugs

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/2423 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 4/24/2025 **Status:** ✅ Merged **Merged:** 6/28/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `tests/create-adapter/dont-gen-id` --- ### 📝 Commits (2) - [`e2712ad`](https://github.com/better-auth/better-auth/commit/e2712ad464303f107168c0b163223c40f27f399f) add: tests for create-adapter to not include an id when generate id is disabled - [`a147628`](https://github.com/better-auth/better-auth/commit/a1476282a47ca3ec903e2caef03866b7f34986f3) chore: minor improvements ### 📊 Changes **1 file changed** (+25 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/create-adapter/test/create-adapter.test.ts` (+25 -0) </details> ### 📄 Description Nothing is broken as of now, just adding another test to prevent future bugs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 21:09:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#29912
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?