github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #2129] [MERGED] fix(stripe): Throw err if passed referenceId when no subscription authorizeReference` is defined #29769

New Issue
Closed
opened 2026-04-17 21:02:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 21:02:38 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/2129
Author: @ping-maxwell
Created: 4/4/2025
Status: ✅ Merged
Merged: 4/10/2025
Merged by: @Bekacru

Base: main ← Head: fix/stripe/reference-id-with-no-authorizeReference

📝 Commits (2)

  • ae6dcd8 fix(stripe): Throw err if passed referenceId when no subscription.authorizeReference is defined
  • 98b39e4 fix: typo

📊 Changes

1 file changed (+7 additions, -0 deletions)

View changed files

📝 packages/stripe/src/index.ts (+7 -0)

📄 Description

If a user uses something like subscription.upgrade and pass a referenceId, but they never defined a options.subscription.authorizeReference then it will throw an error saying unauthorized. (since no function defined, means it will just return false in it's checks)
While this error is valid, it isn't very clear up-front to the developer that it was due to them passing referenceId. To them, they're logged in, so it makes no sense why they would get an unauthorized error.
This PR adds a check if they're missing that function, yet passed referenceId to throw a bad request, and provide more info in the server logs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/2129 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 4/4/2025 **Status:** ✅ Merged **Merged:** 4/10/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix/stripe/reference-id-with-no-authorizeReference` --- ### 📝 Commits (2) - [`ae6dcd8`](https://github.com/better-auth/better-auth/commit/ae6dcd8360b6368afeba597b78905de018e164ae) fix(stripe): Throw err if passed `referenceId` when no `subscription.authorizeReference` is defined - [`98b39e4`](https://github.com/better-auth/better-auth/commit/98b39e4eb4eebca7cb4cbcf62e1fa1880d2b5511) fix: typo ### 📊 Changes **1 file changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/stripe/src/index.ts` (+7 -0) </details> ### 📄 Description If a user uses something like `subscription.upgrade` and pass a `referenceId`, but they never defined a `options.subscription.authorizeReference` then it will throw an error saying unauthorized. (since no function defined, means it will just return `false` in it's checks) While this error is valid, it isn't very clear up-front to the developer that it was due to them passing `referenceId`. To them, they're logged in, so it makes no sense why they would get an unauthorized error. This PR adds a check if they're missing that function, yet passed `referenceId` to throw a bad request, and provide more info in the server logs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 21:02:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#29769
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?