github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1823] [MERGED] fix: allow plus signs in relative callback URLs #29611

New Issue
Closed
opened 2026-04-17 20:54:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 20:54:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1823
Author: @javawizard
Created: 3/14/2025
Status: ✅ Merged
Merged: 3/15/2025
Merged by: @Bekacru

Base: main ← Head: jw/allow-plus-in-urls

📝 Commits (1)

  • 32f4715 fix: allow plus signs in relative callback URLs

📊 Changes

2 files changed (+20 additions, -2 deletions)

View changed files

📝 packages/better-auth/src/api/middlewares/origin-check.test.ts (+18 -0)
📝 packages/better-auth/src/api/middlewares/origin-check.ts (+2 -2)

📄 Description

new URLSearchParams(...).toString() loves to generate +s instead of %20s for spaces; this PR allows them in relative paths.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1823 **Author:** [@javawizard](https://github.com/javawizard) **Created:** 3/14/2025 **Status:** ✅ Merged **Merged:** 3/15/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `jw/allow-plus-in-urls` --- ### 📝 Commits (1) - [`32f4715`](https://github.com/better-auth/better-auth/commit/32f47156b29eebbcd3f0e7c1dcbb5a74516f1606) fix: allow plus signs in relative callback URLs ### 📊 Changes **2 files changed** (+20 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/middlewares/origin-check.test.ts` (+18 -0) 📝 `packages/better-auth/src/api/middlewares/origin-check.ts` (+2 -2) </details> ### 📄 Description `new URLSearchParams(...).toString()` loves to generate `+`s instead of `%20`s for spaces; this PR allows them in relative paths. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 20:54:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#29611
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?