github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-06-04 05:16:36 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1329] [MERGED] Fix incorrect call to getModelName #29359

New Issue
Closed
opened 2026-04-17 20:42:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 20:42:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1329
Author: @chrnorm
Created: 2/1/2025
Status: ✅ Merged
Merged: 2/2/2025
Merged by: @Bekacru

Base: main ← Head: fix-invalid-model-name

📝 Commits (1)

  • 9d0e17b Fix incorrect call to getModelName

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts (+1 -1)

📄 Description

getSchema already calls getModelName. When custom tables are used, this results in a bug where better-auth can't find the table name:

TypeError: undefined is not an object

This PR fixes the incorrect call to getModelName.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1329 **Author:** [@chrnorm](https://github.com/chrnorm) **Created:** 2/1/2025 **Status:** ✅ Merged **Merged:** 2/2/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix-invalid-model-name` --- ### 📝 Commits (1) - [`9d0e17b`](https://github.com/better-auth/better-auth/commit/9d0e17b6a65e79b830d2e211d34a545ed0b32978) Fix incorrect call to `getModelName` ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts` (+1 -1) </details> ### 📄 Description `getSchema` already calls `getModelName`. When custom tables are used, this results in a bug where better-auth can't find the table name: ``` TypeError: undefined is not an object ``` This PR fixes the incorrect call to `getModelName`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 20:42:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#29359
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?