github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-06-09 08:13:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1289] [MERGED] Use redirect URI from options rather than manually overriding #29334

New Issue
Closed
opened 2026-04-17 20:41:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 20:41:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1289
Author: @arlyon
Created: 1/27/2025
Status: ✅ Merged
Merged: 1/29/2025
Merged by: @Bekacru

Base: main ← Head: arlyon/thread-redirect-uri

📝 Commits (1)

  • ae6d669 use redirect URI from options rather than manually overriding

📊 Changes

14 files changed (+15 additions, -13 deletions)

View changed files

📝 packages/better-auth/src/oauth2/validate-authorization-code.ts (+1 -1)
📝 packages/better-auth/src/plugins/generic-oauth/index.ts (+2 -0)
📝 packages/better-auth/src/social-providers/apple.ts (+1 -1)
📝 packages/better-auth/src/social-providers/discord.ts (+1 -1)
📝 packages/better-auth/src/social-providers/dropbox.ts (+1 -1)
📝 packages/better-auth/src/social-providers/facebook.ts (+1 -1)
📝 packages/better-auth/src/social-providers/github.ts (+1 -1)
📝 packages/better-auth/src/social-providers/gitlab.ts (+1 -1)
📝 packages/better-auth/src/social-providers/google.ts (+1 -1)
📝 packages/better-auth/src/social-providers/linkedin.ts (+1 -1)
📝 packages/better-auth/src/social-providers/microsoft-entra-id.ts (+1 -1)
📝 packages/better-auth/src/social-providers/spotify.ts (+1 -1)
📝 packages/better-auth/src/social-providers/twitch.ts (+1 -1)
📝 packages/better-auth/src/social-providers/twitter.ts (+1 -1)

📄 Description

In some places in the codebase we allow the user to override the redirect URI. Sometimes this is respected and sometimes it is not. This change ensures that we handle it consistently, and that it is respected in the generic oauth plugin.

My concrete use case was setting up oauth proxy (the plugin didn't quite fit my use-case) and my generic oauth provider was not behaving.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1289 **Author:** [@arlyon](https://github.com/arlyon) **Created:** 1/27/2025 **Status:** ✅ Merged **Merged:** 1/29/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `arlyon/thread-redirect-uri` --- ### 📝 Commits (1) - [`ae6d669`](https://github.com/better-auth/better-auth/commit/ae6d6690d368437bb0947ac63f0dc3d2850ceefc) use redirect URI from options rather than manually overriding ### 📊 Changes **14 files changed** (+15 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/oauth2/validate-authorization-code.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/generic-oauth/index.ts` (+2 -0) 📝 `packages/better-auth/src/social-providers/apple.ts` (+1 -1) 📝 `packages/better-auth/src/social-providers/discord.ts` (+1 -1) 📝 `packages/better-auth/src/social-providers/dropbox.ts` (+1 -1) 📝 `packages/better-auth/src/social-providers/facebook.ts` (+1 -1) 📝 `packages/better-auth/src/social-providers/github.ts` (+1 -1) 📝 `packages/better-auth/src/social-providers/gitlab.ts` (+1 -1) 📝 `packages/better-auth/src/social-providers/google.ts` (+1 -1) 📝 `packages/better-auth/src/social-providers/linkedin.ts` (+1 -1) 📝 `packages/better-auth/src/social-providers/microsoft-entra-id.ts` (+1 -1) 📝 `packages/better-auth/src/social-providers/spotify.ts` (+1 -1) 📝 `packages/better-auth/src/social-providers/twitch.ts` (+1 -1) 📝 `packages/better-auth/src/social-providers/twitter.ts` (+1 -1) </details> ### 📄 Description In some places in the codebase we allow the user to override the redirect URI. Sometimes this is respected and sometimes it is not. This change ensures that we handle it consistently, and that it is respected in the generic oauth plugin. My concrete use case was setting up oauth proxy (the plugin didn't quite fit my use-case) and my generic oauth provider was not behaving. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 20:41:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#29334
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?