github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

Should better-auth invalidate tokens on unlinkAccount? #2929

New Issue
Open
opened 2026-03-13 10:28:10 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-03-13 10:28:10 -05:00
Owner
Copy Link

Originally created by @rosano on GitHub (Feb 27, 2026).

Is this suited for github?

  • Yes, this is suited for github

Is your feature request related to a problem? Please describe.

It seems like the github accessToken for a linked account is still valid after unlinking the account. Considering that github oauth tokens never expire, should they be invalidated or is that fine as is?

Describe the solution you'd like

Invalidate the token so that it can't be reused somehow.

Describe alternatives you've considered

I might encrypt the tokens to minimize leaks.

Additional context

No response

Originally created by @rosano on GitHub (Feb 27, 2026). ### Is this suited for github? - [x] Yes, this is suited for github ### Is your feature request related to a problem? Please describe. It seems like the github `accessToken` for a linked account is still valid after unlinking the account. Considering that github oauth tokens never expire, should they be invalidated or is that fine as is? ### Describe the solution you'd like Invalidate the token so that it can't be reused somehow. ### Describe alternatives you've considered I might encrypt the tokens to minimize leaks. ### Additional context _No response_
GiteaMirror added the enhancement label 2026-03-13 10:28:10 -05:00
GiteaMirror commented 2026-03-13 10:28:11 -05:00
Author
Owner
Copy Link

@rosano commented on GitHub (Feb 27, 2026):

Currently just using a before hook like this:

import { createAuthMiddleware } from 'better-auth/api';

export const auth = betterAuth({

  // ...

  hooks: {
    before: createAuthMiddleware(async ctx => {
      if (ctx.path === '/unlink-account') {
        const { accessToken } = await auth.api.getAccessToken({
          body: {
            accountId: ctx.body.id,
            providerId: ctx.body.providerId,
          },
          headers: ctx.headers,
        });

        const clientId = process.env.GITHUB_CLIENT_ID;
        const clientSecret = process.env.GITHUB_CLIENT_SECRET;

        const credentials = btoa(`${ clientId }:${ clientSecret }`);
        fetch({
          url: `https://api.github.com/applications/${ clientId }/token`,
          method: 'DELETE',
          headers: {
            'Authorization': `Basic ${ credentials }`,
          },
          body: JSON.stringify({
            access_token: accessToken,
          }),
        })
      }
    }),
  },
})

I guess this gets more annoying and error-prone with more providers so probably nicer for better-auth to 'tidy up' on unlink.

@rosano commented on GitHub (Feb 27, 2026): Currently just using a before hook like this: ```javascript import { createAuthMiddleware } from 'better-auth/api'; export const auth = betterAuth({ // ... hooks: { before: createAuthMiddleware(async ctx => { if (ctx.path === '/unlink-account') { const { accessToken } = await auth.api.getAccessToken({ body: { accountId: ctx.body.id, providerId: ctx.body.providerId, }, headers: ctx.headers, }); const clientId = process.env.GITHUB_CLIENT_ID; const clientSecret = process.env.GITHUB_CLIENT_SECRET; const credentials = btoa(`${ clientId }:${ clientSecret }`); fetch({ url: `https://api.github.com/applications/${ clientId }/token`, method: 'DELETE', headers: { 'Authorization': `Basic ${ credentials }`, }, body: JSON.stringify({ access_token: accessToken, }), }) } }), }, }) ``` I guess this gets more annoying and error-prone with more providers so probably nicer for better-auth to 'tidy up' on unlink.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#2929
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?