github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-27 01:16:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1179] [MERGED] Feature: Disable Implicit Signup for oauth implementations #29273

New Issue
Closed
opened 2026-04-17 20:38:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 20:38:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1179
Author: @kzlar
Created: 1/10/2025
Status: ✅ Merged
Merged: 3/1/2025
Merged by: @Bekacru

Base: main ← Head: feat/oauth-disable-implicit-signup

📝 Commits (9)

  • 47f1b79 Feature: Disable Implicit Signup for oauth implementations
  • d3cfaa5 Merge branch 'main' into feat/oauth-disable-implicit-signup
  • 20cb94d test: remove .only from OAuth2 test cases
  • 9d3fe44 feat: add disableSignUp option for OAuth providers
  • d5d731d Merge branch 'main' into feat/oauth-implicit-signup
  • 90666a4 docs: add OAuth provider configuration options for signup control
  • ac3581d Merge branch 'main' into feat/oauth-disable-implicit-signup
  • 6bb9f07 chore: fix api
  • 25044d4 test: update OAuth test ports to 8081

📊 Changes

12 files changed (+451 additions, -6 deletions)

View changed files

📝 docs/content/docs/concepts/oauth.mdx (+4 -0)
📝 packages/better-auth/src/api/routes/callback.ts (+11 -2)
📝 packages/better-auth/src/api/routes/sign-in.ts (+16 -0)
📝 packages/better-auth/src/init.ts (+6 -1)
📝 packages/better-auth/src/oauth2/link-account.ts (+9 -0)
📝 packages/better-auth/src/oauth2/state.ts (+2 -0)
📝 packages/better-auth/src/oauth2/types.ts (+24 -0)
📝 packages/better-auth/src/plugins/generic-oauth/generic-oauth.test.ts (+109 -0)
📝 packages/better-auth/src/plugins/generic-oauth/index.ts (+26 -2)
📝 packages/better-auth/src/plugins/sso/index.ts (+14 -1)
📝 packages/better-auth/src/plugins/sso/sso.test.ts (+145 -0)
📝 packages/better-auth/src/social-providers/social.test.ts (+85 -0)

📄 Description

  • Added disableImplicitSignup option to social providers, generic oauth privders and sso plugin
  • With disableImplicitSignup as true, signing in with a new email will fail
  • Client may use requestSignUp as true to indicate they're explicitly asking for a sign up
  • Added unit tests for social providers, generic oauth and sso plugin

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1179 **Author:** [@kzlar](https://github.com/kzlar) **Created:** 1/10/2025 **Status:** ✅ Merged **Merged:** 3/1/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `feat/oauth-disable-implicit-signup` --- ### 📝 Commits (9) - [`47f1b79`](https://github.com/better-auth/better-auth/commit/47f1b793f9879a403fa4c841cf9323a2020853b1) Feature: Disable Implicit Signup for oauth implementations - [`d3cfaa5`](https://github.com/better-auth/better-auth/commit/d3cfaa51ba893fa28fdd776f58c397dbc8030759) Merge branch 'main' into feat/oauth-disable-implicit-signup - [`20cb94d`](https://github.com/better-auth/better-auth/commit/20cb94d1309145086134f68651ef32df810062ff) test: remove .only from OAuth2 test cases - [`9d3fe44`](https://github.com/better-auth/better-auth/commit/9d3fe449583cd071d4a03d908ff944843f724fae) feat: add disableSignUp option for OAuth providers - [`d5d731d`](https://github.com/better-auth/better-auth/commit/d5d731d2e9086521bc89240b22a78a2b043068ac) Merge branch 'main' into feat/oauth-implicit-signup - [`90666a4`](https://github.com/better-auth/better-auth/commit/90666a40c1b7283fd00c0039e5bc3bdb82dd0fff) docs: add OAuth provider configuration options for signup control - [`ac3581d`](https://github.com/better-auth/better-auth/commit/ac3581d9656532b115687a729f726fe75254bb17) Merge branch 'main' into feat/oauth-disable-implicit-signup - [`6bb9f07`](https://github.com/better-auth/better-auth/commit/6bb9f072ca7dee2d4241d394a452b7cce63e2159) chore: fix api - [`25044d4`](https://github.com/better-auth/better-auth/commit/25044d43180d8d6326063d5aadb1eda99b14aa31) test: update OAuth test ports to 8081 ### 📊 Changes **12 files changed** (+451 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/concepts/oauth.mdx` (+4 -0) 📝 `packages/better-auth/src/api/routes/callback.ts` (+11 -2) 📝 `packages/better-auth/src/api/routes/sign-in.ts` (+16 -0) 📝 `packages/better-auth/src/init.ts` (+6 -1) 📝 `packages/better-auth/src/oauth2/link-account.ts` (+9 -0) 📝 `packages/better-auth/src/oauth2/state.ts` (+2 -0) 📝 `packages/better-auth/src/oauth2/types.ts` (+24 -0) 📝 `packages/better-auth/src/plugins/generic-oauth/generic-oauth.test.ts` (+109 -0) 📝 `packages/better-auth/src/plugins/generic-oauth/index.ts` (+26 -2) 📝 `packages/better-auth/src/plugins/sso/index.ts` (+14 -1) 📝 `packages/better-auth/src/plugins/sso/sso.test.ts` (+145 -0) 📝 `packages/better-auth/src/social-providers/social.test.ts` (+85 -0) </details> ### 📄 Description - Added disableImplicitSignup option to social providers, generic oauth privders and sso plugin - With disableImplicitSignup as true, signing in with a new email will fail - Client may use requestSignUp as true to indicate they're explicitly asking for a sign up - Added unit tests for social providers, generic oauth and sso plugin --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 20:38:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#29273
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?