github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #1135] [MERGED] chore: added comments to schema unit test code #29250

New Issue
Closed
opened 2026-04-17 20:37:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 20:37:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/1135
Author: @ping-maxwell
Created: 1/4/2025
Status: ✅ Merged
Merged: 1/12/2025
Merged by: @Bekacru

Base: main ← Head: chore/schema-unit-test-comments

📝 Commits (1)

  • 1a114b6 chore: added comments to schema unit test code

📊 Changes

1 file changed (+11 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/adapters/drizzle-adapter/test/schema.ts (+11 -0)

📄 Description

I noticed a user in the BetterAuth Discord server who was reading this file as a reference to creating their schema. This schema file has inaccurate values, but was specifically designed for unit-testing. I added comments at the top to state this.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/1135 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 1/4/2025 **Status:** ✅ Merged **Merged:** 1/12/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `chore/schema-unit-test-comments` --- ### 📝 Commits (1) - [`1a114b6`](https://github.com/better-auth/better-auth/commit/1a114b6b4c5614b3182344065711428b3484d84d) chore: added comments to schema unit test code ### 📊 Changes **1 file changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/drizzle-adapter/test/schema.ts` (+11 -0) </details> ### 📄 Description I noticed a user in the BetterAuth Discord server who was reading this file as a reference to creating their schema. This schema file has inaccurate values, but was specifically designed for unit-testing. I added comments at the top to state this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 20:37:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#29250
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?