github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-06-08 15:26:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #662] [MERGED] fix: always prefer custom generateId function #29022

New Issue
Closed
opened 2026-04-17 20:25:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 20:25:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/662
Author: @jstri
Created: 11/26/2024
Status: ✅ Merged
Merged: 11/26/2024
Merged by: @Bekacru

Base: main ← Head: fix-generateid

📝 Commits (3)

  • e52a9e8 fix: always prefer custom generateid function
  • 11aa0db Add test case
  • 3bc7fcb fix: mongodb skip generateId test

📊 Changes

10 files changed (+95 additions, -62 deletions)

View changed files

📝 packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts (+5 -7)
📝 packages/better-auth/src/adapters/drizzle-adapter/test/adapter.drizzle.test.ts (+3 -1)
📝 packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts (+5 -7)
📝 packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysley.test.ts (+8 -4)
📝 packages/better-auth/src/adapters/memory-adapter/memory-adapter.ts (+5 -7)
📝 packages/better-auth/src/adapters/memory-adapter/memory.test.ts (+9 -6)
📝 packages/better-auth/src/adapters/mongodb-adapter/adapter.mongo-db.test.ts (+13 -10)
📝 packages/better-auth/src/adapters/prisma-adapter/prisma-adapter.ts (+5 -7)
📝 packages/better-auth/src/adapters/prisma-adapter/test/adapter.prisma.test.ts (+12 -9)
📝 packages/better-auth/src/adapters/test.ts (+30 -4)

📄 Description

This PR resolves an issue where the generateId function was not called consistently, specifically when a model id was already provided to the adapter. You can reproduce the issue using the /organization/create API endpoint.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/662 **Author:** [@jstri](https://github.com/jstri) **Created:** 11/26/2024 **Status:** ✅ Merged **Merged:** 11/26/2024 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix-generateid` --- ### 📝 Commits (3) - [`e52a9e8`](https://github.com/better-auth/better-auth/commit/e52a9e8c188e53fe700d7ddce7d604364afbeea9) fix: always prefer custom generateid function - [`11aa0db`](https://github.com/better-auth/better-auth/commit/11aa0db40f41f105c6b22d58309a4b8fa8d7080b) Add test case - [`3bc7fcb`](https://github.com/better-auth/better-auth/commit/3bc7fcbd08618c7cd14debc58460d5065b6a3807) fix: mongodb skip generateId test ### 📊 Changes **10 files changed** (+95 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/adapters/drizzle-adapter/drizzle-adapter.ts` (+5 -7) 📝 `packages/better-auth/src/adapters/drizzle-adapter/test/adapter.drizzle.test.ts` (+3 -1) 📝 `packages/better-auth/src/adapters/kysely-adapter/kysely-adapter.ts` (+5 -7) 📝 `packages/better-auth/src/adapters/kysely-adapter/test/adapter.kysley.test.ts` (+8 -4) 📝 `packages/better-auth/src/adapters/memory-adapter/memory-adapter.ts` (+5 -7) 📝 `packages/better-auth/src/adapters/memory-adapter/memory.test.ts` (+9 -6) 📝 `packages/better-auth/src/adapters/mongodb-adapter/adapter.mongo-db.test.ts` (+13 -10) 📝 `packages/better-auth/src/adapters/prisma-adapter/prisma-adapter.ts` (+5 -7) 📝 `packages/better-auth/src/adapters/prisma-adapter/test/adapter.prisma.test.ts` (+12 -9) 📝 `packages/better-auth/src/adapters/test.ts` (+30 -4) </details> ### 📄 Description This PR resolves an issue where the `generateId` function was not called consistently, specifically when a model `id` was already provided to the adapter. You can reproduce the issue using the `/organization/create` API endpoint. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 20:25:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#29022
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?