github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-07-16 23:20:14 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #582] [CLOSED] fix: correct parameter order for other password verification method #28981

New Issue
Closed
opened 2026-04-17 20:23:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 20:23:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/582
Author: @yasseralsaidi
Created: 11/18/2024
Status: ❌ Closed

Base: next ← Head: main

📝 Commits (3)

  • 1898aaf fix: correct parameter order for password verification method
  • 2406719 Update password.ts
  • 013a2c4 Merge branch 'main' into main

📊 Changes

2 files changed (+12 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/crypto/password.ts (+1 -1)
📝 packages/better-auth/src/init.ts (+11 -0)

📄 Description

found other bug, to correct parameter order for the verify method: Updated the verify function to accept password as the first argument and hash as the second argument.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/582 **Author:** [@yasseralsaidi](https://github.com/yasseralsaidi) **Created:** 11/18/2024 **Status:** ❌ Closed **Base:** `next` ← **Head:** `main` --- ### 📝 Commits (3) - [`1898aaf`](https://github.com/better-auth/better-auth/commit/1898aaf83c97dbc05d58f8986327c386892bb30c) fix: correct parameter order for password verification method - [`2406719`](https://github.com/better-auth/better-auth/commit/24067193dc3f1900f6cf246d57dbcb0eb99d62e7) Update password.ts - [`013a2c4`](https://github.com/better-auth/better-auth/commit/013a2c43b159f120d35c77c2464f9f2a892349fd) Merge branch 'main' into main ### 📊 Changes **2 files changed** (+12 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/crypto/password.ts` (+1 -1) 📝 `packages/better-auth/src/init.ts` (+11 -0) </details> ### 📄 Description found other bug, to correct parameter order for the verify method: Updated the verify function to accept password as the first argument and hash as the second argument. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 20:23:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#28981
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?