github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-30 19:06:47 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #417] [MERGED] Fix Issue 415: Correct forget password redirect #28880

New Issue
Closed
opened 2026-04-17 20:19:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 20:19:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/417
Author: @svaraborut
Created: 11/4/2024
Status: ✅ Merged
Merged: 11/5/2024
Merged by: @Bekacru

Base: main ← Head: fix/reset-password-redirect

📝 Commits (1)

  • 4087c02 fix: Correct forget password redirect

📊 Changes

1 file changed (+33 additions, -9 deletions)

View changed files

📝 packages/better-auth/src/api/routes/forget-password.ts (+33 -9)

📄 Description

Fixed Issue 415

I've added some redirectError and redirectCallback which are candidates to be injected directly to the better-call context and used through all the routes to reduce issues. redirectError is also a candidate function for the implementation of errorCallbackURL proposed in 414.

Fixed also the erroneous behaviour of redirection to the embedded error page if callbackURL is present, but token is missing

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/417 **Author:** [@svaraborut](https://github.com/svaraborut) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 11/5/2024 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `fix/reset-password-redirect` --- ### 📝 Commits (1) - [`4087c02`](https://github.com/better-auth/better-auth/commit/4087c020e75965505f43d0a32ca8fa28c4f2d31f) fix: Correct forget password redirect ### 📊 Changes **1 file changed** (+33 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/routes/forget-password.ts` (+33 -9) </details> ### 📄 Description [Fixed Issue 415](https://github.com/better-auth/better-auth/issues/415) I've added some `redirectError` and `redirectCallback` which are candidates to be injected directly to the `better-call` context and used through all the routes to reduce issues. `redirectError` is also a candidate function for the implementation of `errorCallbackURL` proposed in [414](https://github.com/better-auth/better-auth/issues/414). Fixed also the erroneous behaviour of redirection to the embedded error page if `callbackURL` is present, but `token` is missing --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 20:19:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#28880
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?