github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #389] [MERGED] Verify last otp #28868

New Issue
Closed
opened 2026-04-17 20:18:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 20:18:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/389
Author: @AmineYagoub
Created: 11/1/2024
Status: ✅ Merged
Merged: 11/2/2024
Merged by: @Bekacru

Base: main ← Head: verify-last-otp

📝 Commits (6)

  • e83f190 provide an error message when user cancel passkey resolve #373
  • e86a2d9 refactor: get last code and and delete excess verifications
  • 21ef522 test: create test for otp verification
  • bf4e8ec refactor: Clean up email-otp test code
  • 4298c8a Merge branch 'verify-otp' into verify-last-otp
  • 74fe385 refactor: Remove console.log statement

📊 Changes

4 files changed (+176 additions, -3 deletions)

View changed files

📝 packages/better-auth/src/db/internal-adapter.ts (+18 -2)
📝 packages/better-auth/src/plugins/email-otp/email-otp.test.ts (+43 -0)
📝 packages/better-auth/src/plugins/magic-link/magic-link.test.ts (+61 -1)
📝 packages/better-auth/src/plugins/phone-number/phone-number.test.ts (+54 -0)

📄 Description

close #388

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/389 **Author:** [@AmineYagoub](https://github.com/AmineYagoub) **Created:** 11/1/2024 **Status:** ✅ Merged **Merged:** 11/2/2024 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `main` ← **Head:** `verify-last-otp` --- ### 📝 Commits (6) - [`e83f190`](https://github.com/better-auth/better-auth/commit/e83f1901b0da91892a9a97ca21215258d287b63d) provide an error message when user cancel passkey resolve #373 - [`e86a2d9`](https://github.com/better-auth/better-auth/commit/e86a2d99476c5d3fa8a2c4082c6e3dc0b251b67e) refactor: get last code and and delete excess verifications - [`21ef522`](https://github.com/better-auth/better-auth/commit/21ef5221ca537c3942b5a2b0ea7269a8b995ea91) test: create test for otp verification - [`bf4e8ec`](https://github.com/better-auth/better-auth/commit/bf4e8ec0ddcf3a4e57089a5c8c7da49be9c8dd80) refactor: Clean up email-otp test code - [`4298c8a`](https://github.com/better-auth/better-auth/commit/4298c8a920cd5df469591268978e0183aabff99b) Merge branch 'verify-otp' into verify-last-otp - [`74fe385`](https://github.com/better-auth/better-auth/commit/74fe385e08cf8759023f6b2c886db428484a796d) refactor: Remove console.log statement ### 📊 Changes **4 files changed** (+176 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/db/internal-adapter.ts` (+18 -2) 📝 `packages/better-auth/src/plugins/email-otp/email-otp.test.ts` (+43 -0) 📝 `packages/better-auth/src/plugins/magic-link/magic-link.test.ts` (+61 -1) 📝 `packages/better-auth/src/plugins/phone-number/phone-number.test.ts` (+54 -0) </details> ### 📄 Description close #388 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-17 20:18:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#28868
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?