github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #8705] [PR 8605] Organization deletion lacks a confirmation step, increasing risk of accidental or unauthorized removal #28490

New Issue
Open
opened 2026-04-17 19:56:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 19:56:35 -05:00
Owner
Copy Link

Originally created by @mcorbelli on GitHub (Mar 20, 2026).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/8705

Is this suited for github?

  • Yes, this is suited for github

Is your feature request related to a problem? Please describe.

Currently, the organization plugin allows immediate deletion of an organization via organization.delete without any confirmation step. This creates a risk of accidental deletions or unintended destructive actions, especially in cases where the action is triggered from a UI or by compromised sessions.

In contrast, other sensitive flows (such as user deletion) already implement an email-based verification mechanism, highlighting an inconsistency in how destructive actions are handled across the system.

PR 8605

Describe the solution you'd like

Introduce an optional email confirmation step for organization deletion, similar to the existing deleteUser flow.

When enabled via configuration (e.g. sendDeleteOrganizationEmail):

  • Calling organization.delete should send a verification email instead of immediately deleting the organization

  • The organization owner must confirm the action via:

  1. A callback endpoint (e.g. /organization/delete/callback?token=...), or
  2. A second call to organization.delete including the verification token

  • Tokens should be single-use and expire after a configurable duration

  • The flow should support optional password verification for additional security

  • Safe redirects should be enforced via origin checks

When the option is not configured, the current behavior (immediate deletion) should remain unchanged to avoid breaking existing implementations.

Describe alternatives you've considered

  • Adding a frontend-only confirmation (e.g. modal dialog), which is insufficient as it does not protect against API misuse or compromised sessions

  • Requiring password confirmation only, which improves security but does not provide the same level of explicit user intent verification as email-based confirmation

  • Forcing confirmation for all users, which would introduce a breaking change and reduce flexibility for different use cases

Additional context

No response

Originally created by @mcorbelli on GitHub (Mar 20, 2026). Original GitHub issue: https://github.com/better-auth/better-auth/issues/8705 ### Is this suited for github? - [x] Yes, this is suited for github ### Is your feature request related to a problem? Please describe. Currently, the organization plugin allows immediate deletion of an organization via organization.delete without any confirmation step. This creates a risk of accidental deletions or unintended destructive actions, especially in cases where the action is triggered from a UI or by compromised sessions. In contrast, other sensitive flows (such as user deletion) already implement an email-based verification mechanism, highlighting an inconsistency in how destructive actions are handled across the system. [PR 8605](https://github.com/better-auth/better-auth/pull/8605) ### Describe the solution you'd like Introduce an optional email confirmation step for organization deletion, similar to the existing deleteUser flow. When enabled via configuration (e.g. sendDeleteOrganizationEmail): - Calling organization.delete should send a verification email instead of immediately deleting the organization - The organization owner must confirm the action via: 1. A callback endpoint (e.g. /organization/delete/callback?token=...), or 2. A second call to organization.delete including the verification token - Tokens should be single-use and expire after a configurable duration - The flow should support optional password verification for additional security - Safe redirects should be enforced via origin checks When the option is not configured, the current behavior (immediate deletion) should remain unchanged to avoid breaking existing implementations. ### Describe alternatives you've considered - Adding a frontend-only confirmation (e.g. modal dialog), which is insufficient as it does not protect against API misuse or compromised sessions - Requiring password confirmation only, which improves security but does not provide the same level of explicit user intent verification as email-based confirmation - Forcing confirmation for all users, which would introduce a breaking change and reduce flexibility for different use cases ### Additional context _No response_
GiteaMirror added the securityorganization labels 2026-04-17 19:56:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label organization security
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#28490
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?