github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 08:01:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

Missing nonce generation for genericOAuth (OIDC compatibility) #2756

New Issue
Open
opened 2026-03-13 10:18:29 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-03-13 10:18:29 -05:00
Owner
Copy Link

Originally created by @micchat on GitHub (Jan 23, 2026).

Is this suited for github?

  • Yes, this is suited for github

Is your feature request related to a problem? Please describe.

When using the genericOAuth plugin, the authorization URL is built without generating or including a nonce parameter.

For OAuth/OIDC providers that require or strongly recommend nonce, this can lead to reduced security or incompatibility with certain providers.

Currently, there is no way to enable nonce generation/configuration in genericOAuth.

Expected Behavior

The genericOAuth plugin should be able to generate and include a nonce parameter when constructing the authorization URL, similar to how state is handled.

Describe the solution you'd like

Add an optional configuration flag to genericOAuth, for example:

nonce?: boolean

Describe alternatives you've considered

Manually appending nonce via custom authorization parameters

Additional context

If there is already an internal mechanism or recommended workaround for handling nonce with genericOAuth, documentation or examples would also be helpful.

Originally created by @micchat on GitHub (Jan 23, 2026). ### Is this suited for github? - [x] Yes, this is suited for github ### Is your feature request related to a problem? Please describe. When using the genericOAuth plugin, the authorization URL is built without generating or including a nonce parameter. For OAuth/OIDC providers that require or strongly recommend nonce, this can lead to reduced security or incompatibility with certain providers. Currently, there is no way to enable nonce generation/configuration in genericOAuth. ### Expected Behavior The genericOAuth plugin should be able to generate and include a nonce parameter when constructing the authorization URL, similar to how state is handled. ### Describe the solution you'd like Add an optional configuration flag to genericOAuth, for example: ``` nonce?: boolean ``` ### Describe alternatives you've considered Manually appending nonce via custom authorization parameters ### Additional context If there is already an internal mechanism or recommended workaround for handling nonce with genericOAuth, documentation or examples would also be helpful.
GiteaMirror added the enhancement label 2026-03-13 10:18:29 -05:00
GiteaMirror commented 2026-03-13 10:18:31 -05:00
Author
Owner
Copy Link

@micchat commented on GitHub (Feb 4, 2026):

Is genericOAuth intentionally non-OIDC-compliant, or would supporting optional nonce be acceptable?

@micchat commented on GitHub (Feb 4, 2026): Is genericOAuth intentionally non-OIDC-compliant, or would supporting optional nonce be acceptable?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#2756
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?