github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #5295] list users querying and filtering bug #27530

New Issue
Closed
opened 2026-04-17 18:35:20 -05:00 by GiteaMirror · 7 comments
GiteaMirror commented 2026-04-17 18:35:20 -05:00
Owner
Copy Link

Originally created by @imornar on GitHub (Oct 14, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/5295

GET /admin/list-users docs

Having following dataset:

[
  {name: "mark jackson", email: "markjackson@gmail.com", role: "admin"},
  {name: "mark soberg", email: "marksoberg@admin.com", role: "admin"},
]

result for filter:
{filterValue : "admin", filterField : "role", filterOperator : "eq"}
result: 2 OK ✅

result for search:
{searchValue: "mar", searchField: "email", searchOperator: "contains" }
result: 2 OK ✅

Result for both:
{filterValue : "admin", filterField : "role", filterOperator : "eq", searchValue: "mar", searchField: "email", searchOperator: "contains" }
result: 0 NOT OK ❓

I would expect that this SQL is used:

-- For filter only (role = admin)
SELECT * FROM users
WHERE role = 'admin';

-- For search only (email contains 'mar')
SELECT * FROM users
WHERE email LIKE '%mar%';

-- For both filter AND search combined
SELECT * FROM users
WHERE role = 'admin'
AND email LIKE '%mar%';

-- The combined query should return both records since they match both conditions:
-- 1. mark jackson: role=admin AND email contains 'mar'
-- 2. mark soberg: role=admin AND email contains 'mar'

I'm not sure is this expected behavior or not?

Originally created by @imornar on GitHub (Oct 14, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/5295 GET `/admin/list-users` [docs](https://www.better-auth.com/docs/plugins/admin#list-users) Having following dataset: ``` [ {name: "mark jackson", email: "markjackson@gmail.com", role: "admin"}, {name: "mark soberg", email: "marksoberg@admin.com", role: "admin"}, ] ``` result for filter: `{filterValue : "admin", filterField : "role", filterOperator : "eq"}` result: 2 OK ✅ result for search: `{searchValue: "mar", searchField: "email", searchOperator: "contains" }` result: 2 OK ✅ Result for both: `{filterValue : "admin", filterField : "role", filterOperator : "eq", searchValue: "mar", searchField: "email", searchOperator: "contains" }` result: 0 NOT OK ❓ I would expect that this SQL is used: -- For filter only (role = admin) SELECT * FROM users WHERE role = 'admin'; -- For search only (email contains 'mar') SELECT * FROM users WHERE email LIKE '%mar%'; -- For both filter AND search combined SELECT * FROM users WHERE role = 'admin' AND email LIKE '%mar%'; -- The combined query should return both records since they match both conditions: -- 1. mark jackson: role=admin AND email contains 'mar' -- 2. mark soberg: role=admin AND email contains 'mar' I'm not sure is this expected behavior or not?
GiteaMirror added the lockedbug labels 2026-04-17 18:35:20 -05:00
GiteaMirror commented 2026-04-17 18:35:22 -05:00
Author
Owner
Copy Link

@Kinfe123 commented on GitHub (Oct 14, 2025):

can you please check if those data exists on your db. i have added a test replicating your filters and searches here - #5299

<!-- gh-comment-id:3401671777 --> @Kinfe123 commented on GitHub (Oct 14, 2025): can you please check if those data exists on your db. i have added a test replicating your filters and searches here - #5299
GiteaMirror commented 2026-04-17 18:35:23 -05:00
Author
Owner
Copy Link

@biniam0 commented on GitHub (Oct 14, 2025):

Which database adapter were you using?

<!-- gh-comment-id:3402118671 --> @biniam0 commented on GitHub (Oct 14, 2025): Which database adapter were you using?
GiteaMirror commented 2026-04-17 18:35:24 -05:00
Author
Owner
Copy Link

@Kinfe123 commented on GitHub (Oct 14, 2025):

it has sqlite by default. can you please send your auth config ?

<!-- gh-comment-id:3402151232 --> @Kinfe123 commented on GitHub (Oct 14, 2025): it has sqlite by default. can you please send your auth config ?
GiteaMirror commented 2026-04-17 18:35:24 -05:00
Author
Owner
Copy Link

@imornar commented on GitHub (Oct 14, 2025):

Checked, data exists correctly in database, when using just filters, it works as expected, when using just searches, it work as expected, when I combine both, always empty array.

I'm using postgress with drizzle

import { drizzle } from "drizzle-orm/node-postgres";
import { schema } from "./schema";

export const db = drizzle({
  connection: process.env.DATABASE_URL || "",
  casing: "snake_case",
  schema,
});

with auth config

export const drizzleAdapterOptions: DrizzleAdapterConfig = {
  provider: "pg",
  schema: authSchema,
  usePlural: true,
};

export const authOptions = {
  appName: "AppName",
  database: drizzleAdapter(db, drizzleAdapterOptions),
  user: {
    additionalFields: {
      active: { type: "boolean", defaultValue: true },
      about: { type: "string", required: false },
      firstName: { type: "string", required: true, input: true },
      lastName: { type: "string", required: true },
      phone: { type: "string", required: true },
      addressLine1: { type: "string", required: false },
      addressLine2: { type: "string", required: false },
      city: { type: "string", required: false },
      state: { type: "string", required: false },
      zipCode: { type: "string", required: false },
      country: { type: "string", required: false },
    },
  },
  plugins: [expo(), openAPI(), adminPlugin({ defaultRole: "homeowner" }), twoFactor()],
  emailAndPassword: {
    enabled: true,
    requireEmailVerification: true,
    sendResetPassword: async ({ user, url }, _request) => {
      await sendEmail({
        to: user.email,
        subject: "Reset your password",
        text: `Click the link to reset your password: ${url}`,
      });
    },
  },
  emailVerification: {
    sendOnSignUp: true,
    autoSignInAfterVerification: true,
    sendVerificationEmail: async ({ user, url }, _request) => {
      await sendEmail({
        to: user.email,
        subject: "Verify your email address",
        text: `Click the link to verify your email: ${url}`,
      });
      logger.info(`${user.email} verification email sent`, { id: user.id });
    },
  },
  trustedOrigins: [process.env.CORS_ORIGIN || "", "mybettertapp://", "exp://"],
  advanced: {
    defaultCookieAttributes: {
      sameSite: "none",
      secure: true,
      httpOnly: true,
    },
    database: {
      generateId: false,
    },
  },
} satisfies BetterAuthOptions;

export const auth = betterAuth(authOptions);
<!-- gh-comment-id:3402324323 --> @imornar commented on GitHub (Oct 14, 2025): Checked, data exists correctly in database, when using just filters, it works as expected, when using just searches, it work as expected, when I combine both, always empty array. I'm using postgress with drizzle ``` import { drizzle } from "drizzle-orm/node-postgres"; import { schema } from "./schema"; export const db = drizzle({ connection: process.env.DATABASE_URL || "", casing: "snake_case", schema, }); ``` with auth config ``` export const drizzleAdapterOptions: DrizzleAdapterConfig = { provider: "pg", schema: authSchema, usePlural: true, }; export const authOptions = { appName: "AppName", database: drizzleAdapter(db, drizzleAdapterOptions), user: { additionalFields: { active: { type: "boolean", defaultValue: true }, about: { type: "string", required: false }, firstName: { type: "string", required: true, input: true }, lastName: { type: "string", required: true }, phone: { type: "string", required: true }, addressLine1: { type: "string", required: false }, addressLine2: { type: "string", required: false }, city: { type: "string", required: false }, state: { type: "string", required: false }, zipCode: { type: "string", required: false }, country: { type: "string", required: false }, }, }, plugins: [expo(), openAPI(), adminPlugin({ defaultRole: "homeowner" }), twoFactor()], emailAndPassword: { enabled: true, requireEmailVerification: true, sendResetPassword: async ({ user, url }, _request) => { await sendEmail({ to: user.email, subject: "Reset your password", text: `Click the link to reset your password: ${url}`, }); }, }, emailVerification: { sendOnSignUp: true, autoSignInAfterVerification: true, sendVerificationEmail: async ({ user, url }, _request) => { await sendEmail({ to: user.email, subject: "Verify your email address", text: `Click the link to verify your email: ${url}`, }); logger.info(`${user.email} verification email sent`, { id: user.id }); }, }, trustedOrigins: [process.env.CORS_ORIGIN || "", "mybettertapp://", "exp://"], advanced: { defaultCookieAttributes: { sameSite: "none", secure: true, httpOnly: true, }, database: { generateId: false, }, }, } satisfies BetterAuthOptions; export const auth = betterAuth(authOptions); ```
GiteaMirror commented 2026-04-17 18:35:25 -05:00
Author
Owner
Copy Link

@Kinfe123 commented on GitHub (Oct 14, 2025):

can you check on installing this - npm i https://pkg.pr.new/better-auth/better-auth@5311

<!-- gh-comment-id:3403808143 --> @Kinfe123 commented on GitHub (Oct 14, 2025): can you check on installing this - `npm i https://pkg.pr.new/better-auth/better-auth@5311`
GiteaMirror commented 2026-04-17 18:35:28 -05:00
Author
Owner
Copy Link

@imornar commented on GitHub (Oct 15, 2025):

@Kinfe123 Perfect, that build you provided works correctly 🎊
Can you perhaps tell me more about when this issue might be hotfixed?

Thank you for picking this up so quickly — I’m honestly amazed by the responsiveness! It’s been greatly appreciated. 🙌

<!-- gh-comment-id:3404784220 --> @imornar commented on GitHub (Oct 15, 2025): @Kinfe123 Perfect, that build you provided works correctly 🎊 Can you perhaps tell me more about when this issue might be hotfixed? Thank you for picking this up so quickly — I’m honestly amazed by the responsiveness! It’s been greatly appreciated. 🙌
GiteaMirror commented 2026-04-17 18:35:30 -05:00
Author
Owner
Copy Link

@Kinfe123 commented on GitHub (Oct 15, 2025):

Ref for pr - #5311

<!-- gh-comment-id:3404984942 --> @Kinfe123 commented on GitHub (Oct 15, 2025): Ref for pr - #5311
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#27530
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?