github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #3086] callbackURL do not support wildcard trustedOrigins #26792

New Issue
Closed
opened 2026-04-17 17:29:50 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-04-17 17:29:50 -05:00
Owner
Copy Link

Originally created by @ImSingee on GitHub (Jun 19, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/3086

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

Set trustedOrigins option to ["https://*.example.com"]

Call

await authClient.signIn.magicLink({
  email: "user@email.com",
  callbackURL: "https://xxx.example.com/dashboard",
});

Current vs. Expected behavior

The following error will occur

{"code":"INVALID_CALLBACKURL","message":"Invalid callbackURL"}

What version of Better Auth are you using?

1.2.9

Provide environment information

N/A

Which area(s) are affected? (Select all that apply)

Backend

Auth config (if applicable)

Additional context

The origin-check middleware supports wildcards:

https://github.com/better-auth/better-auth/blob/v1.2.9/packages/better-auth/src/api/middlewares/origin-check.ts#L47-L52

But checkCallbackURL doesn't:

https://github.com/better-auth/better-auth/blob/v1.2.9/packages/better-auth/src/utils/callback-url.ts#L14

Originally created by @ImSingee on GitHub (Jun 19, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/3086 ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce Set `trustedOrigins` option to `["https://*.example.com"]` Call ``` await authClient.signIn.magicLink({ email: "user@email.com", callbackURL: "https://xxx.example.com/dashboard", }); ``` ### Current vs. Expected behavior The following error will occur ```json {"code":"INVALID_CALLBACKURL","message":"Invalid callbackURL"} ``` ### What version of Better Auth are you using? 1.2.9 ### Provide environment information ```bash N/A ``` ### Which area(s) are affected? (Select all that apply) Backend ### Auth config (if applicable) ```typescript ``` ### Additional context The origin-check middleware supports wildcards: https://github.com/better-auth/better-auth/blob/v1.2.9/packages/better-auth/src/api/middlewares/origin-check.ts#L47-L52 But checkCallbackURL doesn't: https://github.com/better-auth/better-auth/blob/v1.2.9/packages/better-auth/src/utils/callback-url.ts#L14
GiteaMirror added the lockedbug labels 2026-04-17 17:29:50 -05:00
GiteaMirror commented 2026-04-17 17:29:53 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Jul 17, 2025):

check callback url isn't actually used by any of the origin checkers. Make sure you're on latest and you have the right configuration of for origins list and it should work

<!-- gh-comment-id:3084712939 --> @Bekacru commented on GitHub (Jul 17, 2025): check callback url isn't actually used by any of the origin checkers. Make sure you're on latest and you have the right configuration of for origins list and it should work
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#26792
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?