github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #2946] forgetPassword is grammatically incorrect #26731

New Issue
Closed
opened 2026-04-17 17:22:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-17 17:22:49 -05:00
Owner
Copy Link

Originally created by @ali-issa on GitHub (Jun 7, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/2946

Is there a specific reason the function is named forgetPassword instead of forgotPassword?

The name forgetPassword sounds like it's intended to delete or remove a password, rather than initiate password recovery. This becomes especially confusing when it's used alongside resetPassword and sendResetPassword, as the naming doesn’t follow a consistent or intuitive pattern. It also affects the professionalism and clarity of the codebase.

Renaming it to requestPasswordReset or maybe forgotPassword would better reflect its purpose and align with common industry conventions.

Originally created by @ali-issa on GitHub (Jun 7, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/2946 Is there a specific reason the function is named `forgetPassword` instead of `forgotPassword`? The name `forgetPassword` sounds like it's intended to delete or remove a password, rather than initiate password recovery. This becomes especially confusing when it's used alongside `resetPassword` and `sendResetPassword`, as the naming doesn’t follow a consistent or intuitive pattern. It also affects the professionalism and clarity of the codebase. Renaming it to `requestPasswordReset` or maybe `forgotPassword` would better reflect its purpose and align with common industry conventions.
GiteaMirror added the locked label 2026-04-17 17:22:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#26731
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?