github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #2769] EntraID token refresh not working #26665

New Issue
Closed
opened 2026-04-17 17:18:57 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-04-17 17:18:57 -05:00
Owner
Copy Link

Originally created by @CarbonNeuron on GitHub (May 24, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/2769

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

social sign on user with entra ID, attempt to refresh the access token. get bad request

Current vs. Expected behavior

following the previous steps, i expected the token refresh to behave normally. but it does not. we get 400 bad request error from Microsoft

What version of Better Auth are you using?

1.2.8

Provide environment information

- OS windows 11
- Browser latest chrome canary (not important)

Which area(s) are affected? (Select all that apply)

Package

Auth config (if applicable)

import { betterAuth } from "better-auth"

export const auth = betterAuth({
  database: prismaAdapter(prisma, {
    provider: 'sqlserver',
  }),
  socialProviders: {
    microsoft: {
      clientId: env.MICROSOFT_ENTRA_ID_ID,
      clientSecret: env.MICROSOFT_ENTRA_ID_SECRET,
      tenantId: env.MICROSOFT_ENTRA_ID_TENANT_ID,
    },
  },
  account: {
    updateAccountOnSignIn: true,
  },
  plugins: [nextCookies()],
  session: {
    cookieCache: {
      enabled: true,
      maxAge: 5 * 60, // Cache duration in seconds
    },
  },
});

Additional context

Looking at the guide here: https://learn.microsoft.com/en-us/graph/auth-v2-user?tabs=http#step-4-use-the-refresh-token-to-renew-an-expired-access-token

and from my previous experiences writing this logic manually, we are missing the scope url parameters. we cannot omit this. This looks like a fairly simple fix here: 43513e98d1/packages/better-auth/src/social-providers/microsoft-entra-id.ts (L119)

also, the documentation on this is a little obscure. But, in order to get a refresh token, we need to have offline_access in our scopes. Stated here: https://learn.microsoft.com/en-us/graph/auth-v2-user?tabs=http#authorization-request

One other small thing is that if we chose to disable the profile picture, we still are opening and establishing a connection with microsoft at least until we finish getting the headers here: 43513e98d1/packages/better-auth/src/social-providers/microsoft-entra-id.ts (L87)

This operation is cheap (although not free) since we are fully establishing a TLS session only to tare it down. although we dont finish reading the body. there isn't a good reason i see to be doing this.

Originally created by @CarbonNeuron on GitHub (May 24, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/2769 ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce social sign on user with entra ID, attempt to refresh the access token. get bad request ### Current vs. Expected behavior following the previous steps, i expected the token refresh to behave normally. but it does not. we get 400 bad request error from Microsoft ### What version of Better Auth are you using? 1.2.8 ### Provide environment information ```bash - OS windows 11 - Browser latest chrome canary (not important) ``` ### Which area(s) are affected? (Select all that apply) Package ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth" export const auth = betterAuth({ database: prismaAdapter(prisma, { provider: 'sqlserver', }), socialProviders: { microsoft: { clientId: env.MICROSOFT_ENTRA_ID_ID, clientSecret: env.MICROSOFT_ENTRA_ID_SECRET, tenantId: env.MICROSOFT_ENTRA_ID_TENANT_ID, }, }, account: { updateAccountOnSignIn: true, }, plugins: [nextCookies()], session: { cookieCache: { enabled: true, maxAge: 5 * 60, // Cache duration in seconds }, }, }); ``` ### Additional context Looking at the guide here: https://learn.microsoft.com/en-us/graph/auth-v2-user?tabs=http#step-4-use-the-refresh-token-to-renew-an-expired-access-token and from my previous experiences writing this logic manually, we are missing the scope url parameters. we cannot omit this. This looks like a fairly simple fix here: https://github.com/better-auth/better-auth/blob/43513e98d1973c15dd2285404955e6475145aa49/packages/better-auth/src/social-providers/microsoft-entra-id.ts#L119 also, the documentation on this is a little obscure. But, in order to get a refresh token, we need to have offline_access in our scopes. Stated here: https://learn.microsoft.com/en-us/graph/auth-v2-user?tabs=http#authorization-request One other small thing is that if we chose to disable the profile picture, we still are opening and establishing a connection with microsoft at least until we finish getting the headers here: https://github.com/better-auth/better-auth/blob/43513e98d1973c15dd2285404955e6475145aa49/packages/better-auth/src/social-providers/microsoft-entra-id.ts#L87 This operation is cheap (although not free) since we are fully establishing a TLS session only to tare it down. although we dont finish reading the body. there isn't a good reason i see to be doing this.
GiteaMirror added the locked label 2026-04-17 17:18:57 -05:00
GiteaMirror commented 2026-04-17 17:18:59 -05:00
Author
Owner
Copy Link

@CarbonNeuron commented on GitHub (May 24, 2025):

Sorry, I should add that if no one gets around to fixing this, I will open a PR to fix these bugs. They're pretty small. Still business critical though haha.

<!-- gh-comment-id:2906241899 --> @CarbonNeuron commented on GitHub (May 24, 2025): Sorry, I should add that if no one gets around to fixing this, I will open a PR to fix these bugs. They're pretty small. Still business critical though haha.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#26665
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?