github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #2655] bug: OIDC client secret required in PKCE flow #26609

New Issue
Closed
opened 2026-04-17 17:14:34 -05:00 by GiteaMirror · 4 comments
GiteaMirror commented 2026-04-17 17:14:34 -05:00
Owner
Copy Link

Originally created by @ndaba1 on GitHub (May 14, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/2655

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

  1. Install the OIDC plugin
  2. Register a client
  3. Initiate oauth flow with PKCE

Current vs. Expected behavior

The OIDC provider cannot work correctly with public clients as pkce is not supported correctly. A client secret is always required in the token endpoint

What version of Better Auth are you using?

1.2.7

Provide environment information

OS: macOS Sonoma 14.3

Which area(s) are affected? (Select all that apply)

Backend

Auth config (if applicable)

import { betterAuth } from "better-auth"
export const auth = betterAuth({
  emailAndPassword: {  
    enabled: true
  },
});

Additional context

No response

Originally created by @ndaba1 on GitHub (May 14, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/2655 ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce 1. Install the OIDC plugin 2. Register a client 3. Initiate oauth flow with PKCE ### Current vs. Expected behavior The OIDC provider cannot work correctly with public clients as pkce is not supported correctly. A client secret is always required in the token endpoint ### What version of Better Auth are you using? 1.2.7 ### Provide environment information ```bash OS: macOS Sonoma 14.3 ``` ### Which area(s) are affected? (Select all that apply) Backend ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth" export const auth = betterAuth({ emailAndPassword: { enabled: true }, }); ``` ### Additional context _No response_
GiteaMirror added the locked label 2026-04-17 17:14:34 -05:00
GiteaMirror commented 2026-04-17 17:14:36 -05:00
Author
Owner
Copy Link

@kziemski commented on GitHub (May 14, 2025):

@ndaba1 were you trying to use bette-auth for MCP auth use case?

<!-- gh-comment-id:2880797619 --> @kziemski commented on GitHub (May 14, 2025): @ndaba1 were you trying to use bette-auth for MCP auth use case?
GiteaMirror commented 2026-04-17 17:14:36 -05:00
Author
Owner
Copy Link

@ndaba1 commented on GitHub (May 15, 2025):

@ndaba1 were you trying to use bette-auth for MCP auth use case?

Not really, no

<!-- gh-comment-id:2882575954 --> @ndaba1 commented on GitHub (May 15, 2025): > [@ndaba1](https://github.com/ndaba1) were you trying to use bette-auth for MCP auth use case? Not really, no
GiteaMirror commented 2026-04-17 17:14:36 -05:00
Author
Owner
Copy Link

@julen commented on GitHub (Aug 14, 2025):

If I'm not mistaken this should've been fixed by #3438.

<!-- gh-comment-id:3188285958 --> @julen commented on GitHub (Aug 14, 2025): If I'm not mistaken this should've been fixed by #3438.
GiteaMirror commented 2026-04-17 17:14:37 -05:00
Author
Owner
Copy Link

@dosubot[bot] commented on GitHub (Nov 13, 2025):

Hi, @ndaba1. I'm Dosu, and I'm helping the better-auth team manage their backlog and am marking this issue as stale.

Issue Summary:

  • You reported a bug in Better Auth v1.2.7 where the OIDC plugin mishandled PKCE, requiring a client secret for public clients during token exchange.
  • Maintainer kziemski asked if this was related to MCP auth, which you clarified it was not.
  • Contributor julen suggested that pull request #3438 likely resolved this issue.

Next Steps:

  • Please let me know if this issue is still relevant with the latest version of better-auth by commenting here.
  • If I don’t hear back from you within 7 days, this issue will be automatically closed.

Thanks for your understanding and contribution!

<!-- gh-comment-id:3528570393 --> @dosubot[bot] commented on GitHub (Nov 13, 2025): Hi, @ndaba1. I'm [Dosu](https://dosu.dev), and I'm helping the better-auth team manage their backlog and am marking this issue as stale. **Issue Summary:** - You reported a bug in Better Auth v1.2.7 where the OIDC plugin mishandled PKCE, requiring a client secret for public clients during token exchange. - Maintainer kziemski asked if this was related to MCP auth, which you clarified it was not. - Contributor julen suggested that pull request #3438 likely resolved this issue. **Next Steps:** - Please let me know if this issue is still relevant with the latest version of better-auth by commenting here. - If I don’t hear back from you within 7 days, this issue will be automatically closed. Thanks for your understanding and contribution!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#26609
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?