github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-08-22 16:42:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #928] Do not require expo-secure-store when providing custom storage #25828

New Issue
Closed
opened 2026-04-17 16:05:51 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-17 16:05:51 -05:00
Owner
Copy Link
Copy Source

Originally created by @hyoban on GitHub (Dec 18, 2024).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/928

Is this suited for github?

  • Yes, this is suited for github

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like

Just remove the dependency on expo-secure-store and let users configure it

Describe alternatives you've considered

Only dynamically import expo-secure-store when no storage is provided

Additional context

I am willing to submit a PR to fix this issue

Originally created by @hyoban on GitHub (Dec 18, 2024). Original GitHub issue: https://github.com/better-auth/better-auth/issues/928 ### Is this suited for github? - [x] Yes, this is suited for github ### Is your feature request related to a problem? Please describe. _No response_ ### Describe the solution you'd like Just remove the dependency on `expo-secure-store` and let users configure it ### Describe alternatives you've considered Only dynamically import `expo-secure-store` when no storage is provided ### Additional context I am willing to submit a PR to fix this issue
GiteaMirror added the locked label 2026-04-17 16:05:51 -05:00
GiteaMirror commented 2026-04-17 16:05:53 -05:00
Author
Owner
Copy Link
Copy Source

@Bekacru commented on GitHub (Dec 18, 2024):

Yeah, good suggestion. would appreciate a PR. I'm not sure if dynamic imports cause any issues with Metro. If they do, we could make the storage user defined. If not, it should be imported dynamically.

<!-- gh-comment-id:2550388788 --> @Bekacru commented on GitHub (Dec 18, 2024): Yeah, good suggestion. would appreciate a PR. I'm not sure if dynamic imports cause any issues with Metro. If they do, we could make the storage user defined. If not, it should be imported dynamically.
GiteaMirror commented 2026-04-17 16:05:54 -05:00
Author
Owner
Copy Link
Copy Source

@hyoban commented on GitHub (Dec 18, 2024):

I tried. Dynamic import works fine, but await import will make the plugin async.

<!-- gh-comment-id:2550828533 --> @hyoban commented on GitHub (Dec 18, 2024): I tried. Dynamic import works fine, but `await import` will make the plugin async.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels locked
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#25828