github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

trustedOrigins is not respected #254

New Issue
Closed
opened 2026-03-13 07:39:52 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-03-13 07:39:52 -05:00
Owner
Copy Link

Originally created by @jakst on GitHub (Nov 20, 2024).

Describe the bug
Adding an origin to trustedOrigins does not have any effect.

import { betterAuth } from "better-auth"
import Database from "better-sqlite3"

export const auth = betterAuth({
  trustedOrigins: ["http://localhost:5173"],
  database: new Database("./sqlite.db"),
})

Requests to sign in from the frontend running at http://localhost:5173 are denied with the following error message.

 ERROR   Invalid origin: http://localhost:5173

ℹ  If it's a valid URL, please add http://localhost:5173 to trustedOrigins in your auth config
 Current list of trustedOrigins: http://localhost:3000

The interesting thing is that the error message adds an extra instance of http://localhost:3000 to the list for each request. So this is what it looks like when doing three requests after each other.

ERROR   Invalid origin: http://localhost:5173

ℹ  If it's a valid URL, please add http://localhost:5173 to trustedOrigins in your auth config
Current list of trustedOrigins: http://localhost:3000

ERROR   Invalid origin: http://localhost:5173

ℹ  If it's a valid URL, please add http://localhost:5173 to trustedOrigins in your auth config
Current list of trustedOrigins: http://localhost:3000,http://localhost:3000

ERROR   Invalid origin: http://localhost:5173

ℹ  If it's a valid URL, please add http://localhost:5173 to trustedOrigins in your auth config
Current list of trustedOrigins: http://localhost:3000,http://localhost:3000,http://localhost:3000

To Reproduce
Steps to reproduce the behavior:

  1. Set up a better-auth server on port 3000. I was following the tutorial for Hono.
  2. Add trustedOrigins: ["http://localhost:5173"] to the config
  3. Set up a frontend on port 5173 and add a signin button that uses the better-auth SDK.
  4. Try to signin
  5. See the error in the auth server logs

Expected behavior
I should be able to trust different origins than the one that the auth server is running on.

Desktop (please complete the following information):

  • OS: MacOS v15.1
  • Browser Chrome
  • Version better-auth v1.0.0-canary.3
Originally created by @jakst on GitHub (Nov 20, 2024). **Describe the bug** Adding an origin to trustedOrigins does not have any effect. ```ts import { betterAuth } from "better-auth" import Database from "better-sqlite3" export const auth = betterAuth({ trustedOrigins: ["http://localhost:5173"], database: new Database("./sqlite.db"), }) ``` Requests to sign in from the frontend running at `http://localhost:5173` are denied with the following error message. ``` ERROR Invalid origin: http://localhost:5173 ℹ If it's a valid URL, please add http://localhost:5173 to trustedOrigins in your auth config Current list of trustedOrigins: http://localhost:3000 ``` The interesting thing is that the error message adds an extra instance of `http://localhost:3000` to the list for each request. So this is what it looks like when doing three requests after each other. ``` ERROR Invalid origin: http://localhost:5173 ℹ If it's a valid URL, please add http://localhost:5173 to trustedOrigins in your auth config Current list of trustedOrigins: http://localhost:3000 ERROR Invalid origin: http://localhost:5173 ℹ If it's a valid URL, please add http://localhost:5173 to trustedOrigins in your auth config Current list of trustedOrigins: http://localhost:3000,http://localhost:3000 ERROR Invalid origin: http://localhost:5173 ℹ If it's a valid URL, please add http://localhost:5173 to trustedOrigins in your auth config Current list of trustedOrigins: http://localhost:3000,http://localhost:3000,http://localhost:3000 ``` **To Reproduce** Steps to reproduce the behavior: 1. Set up a better-auth server on port 3000. I was following the tutorial for Hono. 2. Add `trustedOrigins: ["http://localhost:5173"]` to the config 3. Set up a frontend on port 5173 and add a signin button that uses the better-auth SDK. 4. Try to signin 5. See the error in the auth server logs **Expected behavior** I should be able to trust different origins than the one that the auth server is running on. **Desktop (please complete the following information):** - OS: MacOS v15.1 - Browser Chrome - Version better-auth v1.0.0-canary.3
GiteaMirror commented 2026-03-13 07:39:54 -05:00
Author
Owner
Copy Link

@teukuamru commented on GitHub (Nov 20, 2024):

i can confirm this also happens in version 0.8.8

@teukuamru commented on GitHub (Nov 20, 2024): i can confirm this also happens in version 0.8.8
GiteaMirror commented 2026-03-13 07:39:55 -05:00
Author
Owner
Copy Link

@jakst commented on GitHub (Nov 20, 2024):

This was fixed in v1.0.0-canary.6.

@jakst commented on GitHub (Nov 20, 2024): This was fixed in `v1.0.0-canary.6`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#254
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?