github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #9163] [MERGED] chore: minor review followups on recent main commits #25378

New Issue
Closed
opened 2026-04-15 22:51:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:51:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/9163
Author: @gustavovalverde
Created: 4/14/2026
Status: ✅ Merged
Merged: 4/14/2026
Merged by: @gustavovalverde

Base: main ← Head: fix-cubic-review-findings

📝 Commits (1)

  • e84a713 chore: harden grep -c fallbacks in release validation and related followups

📊 Changes

3 files changed (+9 additions, -5 deletions)

View changed files

📝 .github/workflows/release.yml (+4 -2)
📝 docs/app/api/enterprise/contact/route.ts (+4 -1)
📝 packages/better-auth/src/plugins/two-factor/two-factor.test.ts (+1 -2)

📄 Description

Three correctness followups on recent main commits:

  • release.yml: handle all three grep -c exit paths (match, no-match, error) with || true + ${VAR:-0}. Neither || echo 0 (produces 0\n0 on the no-match case) nor || true alone (leaves the var empty on the missing-file case) covers every path; the commit message spells out the full reasoning.
  • two-factor.test.ts: drop callbackURL from magic-link verify so the assertion reads the JSON body, not a redirect.
  • contact/route.ts: guard non-object JSON body before reading _hp so a null payload doesn't 500.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/9163 **Author:** [@gustavovalverde](https://github.com/gustavovalverde) **Created:** 4/14/2026 **Status:** ✅ Merged **Merged:** 4/14/2026 **Merged by:** [@gustavovalverde](https://github.com/gustavovalverde) **Base:** `main` ← **Head:** `fix-cubic-review-findings` --- ### 📝 Commits (1) - [`e84a713`](https://github.com/better-auth/better-auth/commit/e84a7132cd289caadeee8688283a49885136c25d) chore: harden grep -c fallbacks in release validation and related followups ### 📊 Changes **3 files changed** (+9 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yml` (+4 -2) 📝 `docs/app/api/enterprise/contact/route.ts` (+4 -1) 📝 `packages/better-auth/src/plugins/two-factor/two-factor.test.ts` (+1 -2) </details> ### 📄 Description Three correctness followups on recent `main` commits: - `release.yml`: handle all three `grep -c` exit paths (match, no-match, error) with `|| true` + `${VAR:-0}`. Neither `|| echo 0` (produces `0\n0` on the no-match case) nor `|| true` alone (leaves the var empty on the missing-file case) covers every path; the commit message spells out the full reasoning. - `two-factor.test.ts`: drop `callbackURL` from magic-link verify so the assertion reads the JSON body, not a redirect. - `contact/route.ts`: guard non-object JSON body before reading `_hp` so a `null` payload doesn't 500. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:51:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#25378
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?