github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-06-04 05:16:36 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #9114] [CLOSED] fix(ci): fix grep -c fallback producing invalid integer in release #25346

New Issue
Closed
opened 2026-04-15 22:50:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:50:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/9114
Author: @gustavovalverde
Created: 4/11/2026
Status: ❌ Closed

Base: main ← Head: fix/release-grep-fallback

📝 Commits (1)

  • 72ce3b2 fix(ci): fix grep -c fallback producing invalid integer in release validation

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 .github/workflows/release.yml (+2 -2)

📄 Description

Summary

  • grep -coP outputs 0 to stdout on no matches but exits 1, causing the || echo 0 fallback to append a second 0
  • The resulting multi-line value fails the -lt integer comparison in release note validation
  • Fix: use || true instead, since grep -c already outputs the correct count

Cherry-picked from chore/sync-main-to-next (2e0ad3036).

Summary by cubic

Fixes the release validation workflow by replacing the grep -coP fallback from || echo 0 to || true, so zero matches remain a single 0.
This prevents multi-line counts like 0\n0 that broke the -lt comparison when checking PR link counts.

Written for commit 72ce3b21cc. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/9114 **Author:** [@gustavovalverde](https://github.com/gustavovalverde) **Created:** 4/11/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/release-grep-fallback` --- ### 📝 Commits (1) - [`72ce3b2`](https://github.com/better-auth/better-auth/commit/72ce3b21cc0125a45351645a6aa25e4716c37873) fix(ci): fix grep -c fallback producing invalid integer in release validation ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yml` (+2 -2) </details> ### 📄 Description ## Summary - `grep -coP` outputs `0` to stdout on no matches but exits 1, causing the `|| echo 0` fallback to append a second `0` - The resulting multi-line value fails the `-lt` integer comparison in release note validation - Fix: use `|| true` instead, since `grep -c` already outputs the correct count Cherry-picked from chore/sync-main-to-next (2e0ad3036). <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fixes the release validation workflow by replacing the `grep -coP` fallback from `|| echo 0` to `|| true`, so zero matches remain a single `0`. This prevents multi-line counts like `0\n0` that broke the `-lt` comparison when checking PR link counts. <sup>Written for commit 72ce3b21cc0125a45351645a6aa25e4716c37873. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:50:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#25346
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?