github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8998] [MERGED] refactor(oauth-provider): reject skip_consent at schema level in DCR #25259

New Issue
Closed
opened 2026-04-15 22:47:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:47:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8998
Author: @dvanmali
Created: 4/6/2026
Status: ✅ Merged
Merged: 4/9/2026
Merged by: @gustavovalverde

Base: main ← Head: opRemoveSkipClient

📝 Commits (4)

  • 2dfd8d0 chore: remove skip_consent added to DCR
  • 1f980df fix: specify never type
  • b39113e fix: suggested updates from gustavo
  • 55d996d add changeset

📊 Changes

4 files changed (+12 additions, -9 deletions)

View changed files

➕ .changeset/gentle-trains-knock.md (+5 -0)
📝 packages/oauth-provider/src/oauth.ts (+6 -1)
📝 packages/oauth-provider/src/register.test.ts (+1 -0)
📝 packages/oauth-provider/src/register.ts (+0 -8)

📄 Description

DCR /register endpoint should not accept the skip_consent parameter at all. Removes the parameter from registration client.

Summary by cubic

Remove skip_consent from Dynamic Client Registration in @better-auth/oauth-provider.
The /register endpoint now blocks it via z.never() with a clear error; TypeScript marks it never, tests cover the 400, and the redundant server-side check was removed.

Written for commit 55d996d3aa. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8998 **Author:** [@dvanmali](https://github.com/dvanmali) **Created:** 4/6/2026 **Status:** ✅ Merged **Merged:** 4/9/2026 **Merged by:** [@gustavovalverde](https://github.com/gustavovalverde) **Base:** `main` ← **Head:** `opRemoveSkipClient` --- ### 📝 Commits (4) - [`2dfd8d0`](https://github.com/better-auth/better-auth/commit/2dfd8d0826377f160b15eebca717053a01ed6d71) chore: remove skip_consent added to DCR - [`1f980df`](https://github.com/better-auth/better-auth/commit/1f980df0ba4cd8ac88ad6ebddd957bdb871ab466) fix: specify never type - [`b39113e`](https://github.com/better-auth/better-auth/commit/b39113e2fed23e67a412b0214a48f8acb36ef011) fix: suggested updates from gustavo - [`55d996d`](https://github.com/better-auth/better-auth/commit/55d996d3aa47854615dea4b9d9b5ae0d3d519d0e) add changeset ### 📊 Changes **4 files changed** (+12 additions, -9 deletions) <details> <summary>View changed files</summary> ➕ `.changeset/gentle-trains-knock.md` (+5 -0) 📝 `packages/oauth-provider/src/oauth.ts` (+6 -1) 📝 `packages/oauth-provider/src/register.test.ts` (+1 -0) 📝 `packages/oauth-provider/src/register.ts` (+0 -8) </details> ### 📄 Description DCR `/register` endpoint should not accept the `skip_consent` parameter at all. Removes the parameter from registration client. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Remove `skip_consent` from Dynamic Client Registration in `@better-auth/oauth-provider`. The `/register` endpoint now blocks it via `z.never()` with a clear error; TypeScript marks it `never`, tests cover the 400, and the redundant server-side check was removed. <sup>Written for commit 55d996d3aa47854615dea4b9d9b5ae0d3d519d0e. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:47:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#25259
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?