github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8991] [MERGED] chore: sync main to next #25254

New Issue
Closed
opened 2026-04-15 22:47:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:47:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8991
Author: @better-release[bot]
Created: 4/6/2026
Status: ✅ Merged
Merged: 4/6/2026
Merged by: @gustavovalverde

Base: next ← Head: main

📝 Commits (1)

  • 141781d fix: generate session id when using secondary storage without database (#8927)

📊 Changes

4 files changed (+21 additions, -2 deletions)

View changed files

➕ .changeset/pr-8927.md (+5 -0)
📝 e2e/smoke/test/redis.spec.ts (+2 -2)
📝 packages/better-auth/src/db/internal-adapter.test.ts (+5 -0)
📝 packages/better-auth/src/db/internal-adapter.ts (+9 -0)

📄 Description

Brings stable fixes from main into the next branch.

This PR must be merged by a maintainer using 'Create a merge commit' (not squash, not rebase). This preserves individual fix commits and their verified signatures.

If there are conflicts, resolve them by keeping next's versions for package.json files (next is always ahead of main in version numbers).

Summary by cubic

Syncs stable fixes into next and ensures better-auth always sets a session id when using only secondary storage (no DB). Updates tests to expect a defined session.id.

  • Bug Fixes
    • In better-auth, generate a session id when secondaryStorage is used without storeInDb (uses ctx.generateId or a fallback).
    • Updated Redis e2e and internal adapter tests to assert session.id is present.

Written for commit 141781d6fc. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8991 **Author:** [@better-release[bot]](https://github.com/apps/better-release) **Created:** 4/6/2026 **Status:** ✅ Merged **Merged:** 4/6/2026 **Merged by:** [@gustavovalverde](https://github.com/gustavovalverde) **Base:** `next` ← **Head:** `main` --- ### 📝 Commits (1) - [`141781d`](https://github.com/better-auth/better-auth/commit/141781d6fc98255b5db90363374add314f3095d7) fix: generate session id when using secondary storage without database (#8927) ### 📊 Changes **4 files changed** (+21 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `.changeset/pr-8927.md` (+5 -0) 📝 `e2e/smoke/test/redis.spec.ts` (+2 -2) 📝 `packages/better-auth/src/db/internal-adapter.test.ts` (+5 -0) 📝 `packages/better-auth/src/db/internal-adapter.ts` (+9 -0) </details> ### 📄 Description Brings stable fixes from main into the next branch. **This PR must be merged by a maintainer using 'Create a merge commit'** (not squash, not rebase). This preserves individual fix commits and their verified signatures. If there are conflicts, resolve them by keeping next's versions for `package.json` files (next is always ahead of main in version numbers). <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Syncs stable fixes into `next` and ensures `better-auth` always sets a session id when using only secondary storage (no DB). Updates tests to expect a defined `session.id`. - **Bug Fixes** - In `better-auth`, generate a session id when `secondaryStorage` is used without `storeInDb` (uses `ctx.generateId` or a fallback). - Updated Redis e2e and internal adapter tests to assert `session.id` is present. <sup>Written for commit 141781d6fc98255b5db90363374add314f3095d7. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:47:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#25254
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?