github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8973] [MERGED] chore: revert better-call v2 migration, downgrade to v1.3.5 #25238

New Issue
Closed
opened 2026-04-15 22:46:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:46:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8973
Author: @bytaesu
Created: 4/5/2026
Status: ✅ Merged
Merged: 4/5/2026
Merged by: @bytaesu

Base: main ← Head: chore/downgrade-better-call-v1

📝 Commits (4)

  • e6e1997 chore: revert better-call v2 migration, downgrade to v1.3.5
  • 4300ff6 fix(types): guard HasRequiredKeys against any
  • d56e0da fix(client): guard InferCtx against any body collapse
  • a19dc52 fix(organization): filter schema keys without additionalFields

📊 Changes

25 files changed (+182 additions, -311 deletions)

View changed files

📝 packages/better-auth/src/api/index.test.ts (+2 -3)
📝 packages/better-auth/src/api/routes/sign-in.ts (+1 -1)
📝 packages/better-auth/src/api/routes/sign-up.test.ts (+1 -1)
📝 packages/better-auth/src/api/routes/update-user.test.ts (+1 -1)
📝 packages/better-auth/src/api/routes/update-user.ts (+1 -1)
📝 packages/better-auth/src/api/to-auth-endpoints.test.ts (+1 -1)
📝 packages/better-auth/src/api/to-auth-endpoints.ts (+5 -20)
📝 packages/better-auth/src/client/path-to-object.ts (+29 -60)
📝 packages/better-auth/src/plugins/anonymous/types.ts (+3 -6)
📝 packages/better-auth/src/plugins/open-api/generator.ts (+5 -5)
📝 packages/better-auth/src/plugins/organization/client.test.ts (+2 -2)
📝 packages/better-auth/src/plugins/organization/client.ts (+3 -1)
📝 packages/better-auth/src/plugins/organization/organization.test.ts (+33 -9)
📝 packages/better-auth/src/plugins/organization/organization.ts (+2 -2)
📝 packages/better-auth/src/plugins/organization/routes/crud-members.test.ts (+1 -1)
📝 packages/better-auth/src/plugins/organization/schema.ts (+1 -1)
📝 packages/better-auth/src/plugins/username/username.test.ts (+1 -9)
📝 packages/better-auth/src/types/api.ts (+4 -4)
📝 packages/better-auth/src/types/types.test.ts (+25 -0)
📝 packages/core/src/api/index.ts (+41 -151)

...and 5 more files

📄 Description

Reverts #8021 (better-call v2 migration), downgrading to v1.3.5

  • The following post-#8021 commits conflicted with the revert and were manually reconciled:
    • #8027 - to-auth-endpoints.ts: added getOperationId(endpoint: Endpoint) using v2's Endpoint type. Changed parameter to v1's Endpoint which has the same options/path shape.
    • #7521 - to-auth-endpoints.ts: added shouldReturnResponse logic around v2's InputContext<6 args>. Reverted to v1's InputContext<2 args> while keeping the logic.
    • #8466 - path-to-object.ts: changed InferRoutes to Record<string, unknown>, kept as-is. core/api/index.ts: added NormalizeMethod and const Method for v2 flat generics, dropped since v1 uses EndpointOptions instead of individual Method generic.
    • #8448 - path-to-object.ts: added MergeCustomSessionWithInferred using v2's Endpoint<8 args> for Meta inference. Changed to use v1's T["options"]["metadata"] access pattern.
    • #8750 - plugin.ts, context.ts, organization/client.ts, organization.ts: added version field. No conflict with v2 types, kept as-is.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8973 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 4/5/2026 **Status:** ✅ Merged **Merged:** 4/5/2026 **Merged by:** [@bytaesu](https://github.com/bytaesu) **Base:** `main` ← **Head:** `chore/downgrade-better-call-v1` --- ### 📝 Commits (4) - [`e6e1997`](https://github.com/better-auth/better-auth/commit/e6e1997eef769676bb4e7938b2758e840bb891d1) chore: revert better-call v2 migration, downgrade to v1.3.5 - [`4300ff6`](https://github.com/better-auth/better-auth/commit/4300ff6dfeede47f67ec89d0675ca31843c37b29) fix(types): guard HasRequiredKeys against any - [`d56e0da`](https://github.com/better-auth/better-auth/commit/d56e0da7f0cce7b982840a2a28cf09b3ea46b497) fix(client): guard InferCtx against any body collapse - [`a19dc52`](https://github.com/better-auth/better-auth/commit/a19dc526e796c96dd3b94d1230e2843cc70c9ce7) fix(organization): filter schema keys without additionalFields ### 📊 Changes **25 files changed** (+182 additions, -311 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/index.test.ts` (+2 -3) 📝 `packages/better-auth/src/api/routes/sign-in.ts` (+1 -1) 📝 `packages/better-auth/src/api/routes/sign-up.test.ts` (+1 -1) 📝 `packages/better-auth/src/api/routes/update-user.test.ts` (+1 -1) 📝 `packages/better-auth/src/api/routes/update-user.ts` (+1 -1) 📝 `packages/better-auth/src/api/to-auth-endpoints.test.ts` (+1 -1) 📝 `packages/better-auth/src/api/to-auth-endpoints.ts` (+5 -20) 📝 `packages/better-auth/src/client/path-to-object.ts` (+29 -60) 📝 `packages/better-auth/src/plugins/anonymous/types.ts` (+3 -6) 📝 `packages/better-auth/src/plugins/open-api/generator.ts` (+5 -5) 📝 `packages/better-auth/src/plugins/organization/client.test.ts` (+2 -2) 📝 `packages/better-auth/src/plugins/organization/client.ts` (+3 -1) 📝 `packages/better-auth/src/plugins/organization/organization.test.ts` (+33 -9) 📝 `packages/better-auth/src/plugins/organization/organization.ts` (+2 -2) 📝 `packages/better-auth/src/plugins/organization/routes/crud-members.test.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/organization/schema.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/username/username.test.ts` (+1 -9) 📝 `packages/better-auth/src/types/api.ts` (+4 -4) 📝 `packages/better-auth/src/types/types.test.ts` (+25 -0) 📝 `packages/core/src/api/index.ts` (+41 -151) _...and 5 more files_ </details> ### 📄 Description Reverts #8021 (better-call v2 migration), downgrading to v1.3.5 - The following post-#8021 commits conflicted with the revert and were manually reconciled: - #8027 - to-auth-endpoints.ts: added getOperationId(endpoint: Endpoint) using v2's Endpoint type. Changed parameter to v1's Endpoint which has the same options/path shape. - #7521 - to-auth-endpoints.ts: added shouldReturnResponse logic around v2's InputContext<6 args>. Reverted to v1's InputContext<2 args> while keeping the logic. - #8466 - path-to-object.ts: changed InferRoutes to Record<string, unknown>, kept as-is. core/api/index.ts: added NormalizeMethod and const Method for v2 flat generics, dropped since v1 uses EndpointOptions instead of individual Method generic. - #8448 - path-to-object.ts: added MergeCustomSessionWithInferred using v2's Endpoint<8 args> for Meta inference. Changed to use v1's T["options"]["metadata"] access pattern. - #8750 - plugin.ts, context.ts, organization/client.ts, organization.ts: added version field. No conflict with v2 types, kept as-is. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:46:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#25238
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?