github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8955] [MERGED] chore: update CODEOWNERS with domain-based team ownership #25223

New Issue
Closed
opened 2026-04-15 22:46:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:46:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8955
Author: @gustavovalverde
Created: 4/4/2026
Status: ✅ Merged
Merged: 4/4/2026
Merged by: @gustavovalverde

Base: main ← Head: chore/update-codeowners

📝 Commits (1)

  • cd6f9d2 chore: update CODEOWNERS with domain-based team ownership

📊 Changes

1 file changed (+57 additions, -2 deletions)

View changed files

📝 .github/CODEOWNERS (+57 -2)

📄 Description

Summary

Replace the flat * @Bekacru @himself65 rule with granular path-based ownership mapped to domain teams.

Team updates applied

  • All domain teams granted Write access to the repo (required for CODEOWNERS)
  • Removed dan-better-auth from domain teams (separate hierarchy)
  • Added ping-maxwell to @better-auth/core
  • Added jonathansamines to @better-auth/platform

How it works

  • * @better-auth/core is the global fallback — covers core, devtools, infra, and anything unlisted
  • Only paths that need a DIFFERENT team have explicit lines
  • Last matching pattern wins (broadest first, most specific last)
  • Using informational mode (no "Require review from Code Owners" in branch protection)

Summary by cubic

Switch CODEOWNERS to domain-based, path-scoped ownership so reviews go to the right teams, with @better-auth/core as the default fallback. Keeps code owner checks informational only.

  • Refactors
    • Replaced * catch-all with domain-based path rules (database, identity/auth, plugins, platform, docs); last match wins.
    • Global fallback is @better-auth/core; only overrides are listed; code owner reviews not required.
    • Team updates: granted Write to domain teams; removed dan-better-auth; added ping-maxwell to @better-auth/core; added jonathansamines to @better-auth/platform.

Written for commit cd6f9d2c31. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8955 **Author:** [@gustavovalverde](https://github.com/gustavovalverde) **Created:** 4/4/2026 **Status:** ✅ Merged **Merged:** 4/4/2026 **Merged by:** [@gustavovalverde](https://github.com/gustavovalverde) **Base:** `main` ← **Head:** `chore/update-codeowners` --- ### 📝 Commits (1) - [`cd6f9d2`](https://github.com/better-auth/better-auth/commit/cd6f9d2c31cc70ae562669014a1fd518c1be4140) chore: update CODEOWNERS with domain-based team ownership ### 📊 Changes **1 file changed** (+57 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/CODEOWNERS` (+57 -2) </details> ### 📄 Description ## Summary Replace the flat `* @Bekacru @himself65` rule with granular path-based ownership mapped to domain teams. ### Team updates applied - All domain teams granted Write access to the repo (required for CODEOWNERS) - Removed `dan-better-auth` from domain teams (separate hierarchy) - Added `ping-maxwell` to `@better-auth/core` - Added `jonathansamines` to `@better-auth/platform` ### How it works - `* @better-auth/core` is the global fallback — covers core, devtools, infra, and anything unlisted - Only paths that need a DIFFERENT team have explicit lines - Last matching pattern wins (broadest first, most specific last) - Using informational mode (no "Require review from Code Owners" in branch protection) <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Switch CODEOWNERS to domain-based, path-scoped ownership so reviews go to the right teams, with `@better-auth/core` as the default fallback. Keeps code owner checks informational only. - **Refactors** - Replaced `*` catch-all with domain-based path rules (database, identity/auth, plugins, platform, docs); last match wins. - Global fallback is `@better-auth/core`; only overrides are listed; code owner reviews not required. - Team updates: granted Write to domain teams; removed `dan-better-auth`; added `ping-maxwell` to `@better-auth/core`; added `jonathansamines` to `@better-auth/platform`. <sup>Written for commit cd6f9d2c31cc70ae562669014a1fd518c1be4140. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:46:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#25223
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?