github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8827] [MERGED] docs: fix missing secret param in getSignedCookie example #25140

New Issue
Closed
opened 2026-04-15 22:44:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:44:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8827
Author: @dipan-ck
Created: 3/29/2026
Status: ✅ Merged
Merged: 4/9/2026
Merged by: @ping-maxwell

Base: main ← Head: docs/fix-signed-cookie-missing-secret

📝 Commits (2)

  • a0c8a29 docs: fix missing secret param in getSignedCookie example
  • 776649d Merge branch 'main' into docs/fix-signed-cookie-missing-secret

📄 Description

What does this PR do?

Fixes the remaining typo from #8789 that was missed in #8813.

Changes

  • ctx.getSignedCookie("my-signed-cookie") → ctx.getSignedCookie("my-signed-cookie", ctx.context.secret)

Related Issue

Partially resolves #8789

Summary by cubic

Fix the hooks docs example for getSignedCookie by adding the missing secret parameter so the sample works as intended: await ctx.getSignedCookie("my-signed-cookie", ctx.context.secret).

Written for commit 776649dbe3. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8827 **Author:** [@dipan-ck](https://github.com/dipan-ck) **Created:** 3/29/2026 **Status:** ✅ Merged **Merged:** 4/9/2026 **Merged by:** [@ping-maxwell](https://github.com/ping-maxwell) **Base:** `main` ← **Head:** `docs/fix-signed-cookie-missing-secret` --- ### 📝 Commits (2) - [`a0c8a29`](https://github.com/better-auth/better-auth/commit/a0c8a29eb6728b5ab06767eb742a6b1786ee3b1f) docs: fix missing secret param in getSignedCookie example - [`776649d`](https://github.com/better-auth/better-auth/commit/776649dbe3adeeeb614a53e01bc00975a0fd85bc) Merge branch 'main' into docs/fix-signed-cookie-missing-secret ### 📄 Description ## What does this PR do? Fixes the remaining typo from #8789 that was missed in #8813. ## Changes - `ctx.getSignedCookie("my-signed-cookie")` → `ctx.getSignedCookie("my-signed-cookie", ctx.context.secret)` ## Related Issue Partially resolves #8789 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix the hooks docs example for `getSignedCookie` by adding the missing secret parameter so the sample works as intended: `await ctx.getSignedCookie("my-signed-cookie", ctx.context.secret)`. <sup>Written for commit 776649dbe3adeeeb614a53e01bc00975a0fd85bc. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:44:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#25140
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?