github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8786] [MERGED] fix: compare account cookie by provider accountId instead of internal id #25111

New Issue
Closed
opened 2026-04-15 22:43:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:43:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8786
Author: @bytaesu
Created: 3/26/2026
Status: ✅ Merged
Merged: 3/30/2026
Merged by: @gustavovalverde

Base: main ← Head: 2026-03-26/fix/account-cookie-id-mismatch

📝 Commits (5)

  • a994376 fix: compare account cookie by provider accountId instead of internal id
  • 9062197 fix: format
  • 4a4a0a9 test: clean up account cookie regression test assertions
  • 4bdef4d fix: validate userId when matching account cookie in getAccessToken and refreshToken
  • b2b2ed9 Merge branch 'main' into 2026-03-26/fix/account-cookie-id-mismatch

📊 Changes

2 files changed (+140 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/api/routes/account.test.ts (+137 -0)
📝 packages/better-auth/src/api/routes/account.ts (+3 -1)

📄 Description

Looks like a leftover from the PR #8346

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8786 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 3/26/2026 **Status:** ✅ Merged **Merged:** 3/30/2026 **Merged by:** [@gustavovalverde](https://github.com/gustavovalverde) **Base:** `main` ← **Head:** `2026-03-26/fix/account-cookie-id-mismatch` --- ### 📝 Commits (5) - [`a994376`](https://github.com/better-auth/better-auth/commit/a9943766bd7d3176b337630deff74087071b3bcc) fix: compare account cookie by provider accountId instead of internal id - [`9062197`](https://github.com/better-auth/better-auth/commit/9062197bf06d1d2317a3a696431f6459cfb4fee5) fix: format - [`4a4a0a9`](https://github.com/better-auth/better-auth/commit/4a4a0a912e34e138ffea12ccc67c1a686d4d5635) test: clean up account cookie regression test assertions - [`4bdef4d`](https://github.com/better-auth/better-auth/commit/4bdef4d8d67c6dd9b2307b05a5d8f42a54626d0d) fix: validate userId when matching account cookie in getAccessToken and refreshToken - [`b2b2ed9`](https://github.com/better-auth/better-auth/commit/b2b2ed99a997bd6659e116b9f56dead83ae8f26f) Merge branch 'main' into 2026-03-26/fix/account-cookie-id-mismatch ### 📊 Changes **2 files changed** (+140 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/routes/account.test.ts` (+137 -0) 📝 `packages/better-auth/src/api/routes/account.ts` (+3 -1) </details> ### 📄 Description Looks like a leftover from the PR #8346 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:43:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#25111
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?