github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8735] [MERGED] fix(sso): skip state cookie check for SAML ACS cross-site POST #25081

New Issue
Closed
opened 2026-04-15 22:43:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:43:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8735
Author: @bytaesu
Created: 3/22/2026
Status: ✅ Merged
Merged: 3/22/2026
Merged by: @Bekacru

Base: canary ← Head: 2026-03-23/fix/saml-relay-state-cookie-check

📝 Commits (2)

  • b4ed8d9 fix(sso): skip state cookie check for SAML ACS cross-site POST
  • c39e54c fix: use nullish coalescing for skipStateCookieCheck to respect explicit false

📊 Changes

3 files changed (+170 additions, -2 deletions)

View changed files

📝 packages/better-auth/src/state.ts (+8 -2)
📝 packages/sso/src/saml-state.ts (+5 -0)
📝 packages/sso/src/saml.test.ts (+157 -0)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8735 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 3/22/2026 **Status:** ✅ Merged **Merged:** 3/22/2026 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `2026-03-23/fix/saml-relay-state-cookie-check` --- ### 📝 Commits (2) - [`b4ed8d9`](https://github.com/better-auth/better-auth/commit/b4ed8d987685777cfb20d788e7a29c807752fb26) fix(sso): skip state cookie check for SAML ACS cross-site POST - [`c39e54c`](https://github.com/better-auth/better-auth/commit/c39e54c4cbe0a044980b9ba0527e294b3693b314) fix: use nullish coalescing for skipStateCookieCheck to respect explicit false ### 📊 Changes **3 files changed** (+170 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/state.ts` (+8 -2) 📝 `packages/sso/src/saml-state.ts` (+5 -0) 📝 `packages/sso/src/saml.test.ts` (+157 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:43:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#25081
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?