github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8663] [MERGED] fix(docs): add missing Encore icon to sidebar icons #25029

New Issue
Closed
opened 2026-04-15 22:41:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:41:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8663
Author: @himself65
Created: 3/17/2026
Status: ✅ Merged
Merged: 3/17/2026
Merged by: @himself65

Base: canary ← Head: fix/encore-sidebar-icon

📝 Commits (1)

  • 9e914af fix(docs): add missing Encore icon to sidebar icons

📊 Changes

1 file changed (+14 additions, -0 deletions)

View changed files

📝 landing/components/icons/index.tsx (+14 -0)

📄 Description

Summary

  • The Encore integration docs PR (#7760) added the encore icon to landing/components/docs/icons.tsx but missed adding it to landing/components/icons/index.tsx
  • sidebar-content.tsx imports Icons from ./icons (i.e., landing/components/icons/index.tsx), causing a type error: Property 'encore' does not exist on type
  • Added the encore SVG icon to the sidebar icons file to fix the build

Test plan

  • pnpm typecheck passes
  • CI lint and build checks pass

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8663 **Author:** [@himself65](https://github.com/himself65) **Created:** 3/17/2026 **Status:** ✅ Merged **Merged:** 3/17/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/encore-sidebar-icon` --- ### 📝 Commits (1) - [`9e914af`](https://github.com/better-auth/better-auth/commit/9e914af0070531f303a3f83a4d1cbeb06ddc032d) fix(docs): add missing Encore icon to sidebar icons ### 📊 Changes **1 file changed** (+14 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `landing/components/icons/index.tsx` (+14 -0) </details> ### 📄 Description ## Summary - The Encore integration docs PR (#7760) added the `encore` icon to `landing/components/docs/icons.tsx` but missed adding it to `landing/components/icons/index.tsx` - `sidebar-content.tsx` imports `Icons` from `./icons` (i.e., `landing/components/icons/index.tsx`), causing a type error: `Property 'encore' does not exist on type` - Added the `encore` SVG icon to the sidebar icons file to fix the build ## Test plan - [x] `pnpm typecheck` passes - [x] CI lint and build checks pass --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:41:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#25029
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?