github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-30 10:56:31 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8647] [CLOSED] fix(sso): read SAML InResponseTo from correct path #25017

New Issue
Closed
opened 2026-04-15 22:41:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:41:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8647
Author: @himself65
Created: 3/17/2026
Status: ❌ Closed

Base: main ← Head: fix/8607-saml-inresponseto

📝 Commits (1)

  • 2ac8e5d fix(sso): read SAML InResponseTo from correct path (#8607)

📊 Changes

2 files changed (+7 additions, -7 deletions)

View changed files

📝 packages/sso/src/routes/sso.ts (+4 -6)
📝 packages/sso/src/types.ts (+3 -1)

📄 Description

Summary

  • Fix SAML InResponseTo validation that always fails when enableInResponseToValidation is enabled
  • samlify's extractor nests InResponseTo under extract.response, but the two login handlers read extract.inResponseTo (always undefined)
  • The logout handler already used the correct path extract?.response?.inResponseTo

Closes #8607
Closes #8608

Test plan

  • Enable enableInResponseToValidation with allowIdpInitiated: false
  • Initiate SP-initiated SAML login — should now succeed instead of being rejected

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8647 **Author:** [@himself65](https://github.com/himself65) **Created:** 3/17/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/8607-saml-inresponseto` --- ### 📝 Commits (1) - [`2ac8e5d`](https://github.com/better-auth/better-auth/commit/2ac8e5d312c499b9c6b9d2abf1a77bbbb40ab0cf) fix(sso): read SAML InResponseTo from correct path (#8607) ### 📊 Changes **2 files changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/sso/src/routes/sso.ts` (+4 -6) 📝 `packages/sso/src/types.ts` (+3 -1) </details> ### 📄 Description ## Summary - Fix SAML InResponseTo validation that always fails when `enableInResponseToValidation` is enabled - `samlify`'s extractor nests `InResponseTo` under `extract.response`, but the two login handlers read `extract.inResponseTo` (always `undefined`) - The logout handler already used the correct path `extract?.response?.inResponseTo` Closes #8607 Closes #8608 ## Test plan - Enable `enableInResponseToValidation` with `allowIdpInitiated: false` - Initiate SP-initiated SAML login — should now succeed instead of being rejected --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:41:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#25017
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?