github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8564] [MERGED] feat(test-utils): export adapter test suites from @better-auth/test-utils/adapter #24964

New Issue
Closed
opened 2026-04-15 22:39:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:39:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8564
Author: @bytaesu
Created: 3/12/2026
Status: ✅ Merged
Merged: 3/12/2026
Merged by: @himself65

Base: canary ← Head: 2026-03-12/feat/export-adapter-test-suites

📝 Commits (1)

  • 8e00a92 feat(test-utils): export adapter test suites from '@better-auth/test-utils/adapter'

📊 Changes

9 files changed (+23 additions, -16 deletions)

View changed files

📝 e2e/adapter/test/adapter-factory/index.ts (+9 -6)
📝 packages/test-utils/src/adapter/index.ts (+1 -0)
📝 packages/test-utils/src/adapter/suites/auth-flow.ts (+1 -1)
📝 packages/test-utils/src/adapter/suites/basic.ts (+1 -1)
➕ packages/test-utils/src/adapter/suites/index.ts (+6 -0)
📝 packages/test-utils/src/adapter/suites/joins.ts (+1 -1)
📝 packages/test-utils/src/adapter/suites/number-id.ts (+2 -5)
📝 packages/test-utils/src/adapter/suites/transactions.ts (+1 -1)
📝 packages/test-utils/src/adapter/suites/uuid.ts (+1 -1)

📄 Description

Related to https://github.com/get-convex/better-auth/pull/292#issuecomment-4041495725

This code was used for our internal e2e tests, so I'm not sure if it's appropriate to export it from the package. While it could be helpful for external users building adapters, it would also make it harder for us to freely change our internal tests and introduce additional maintenance overhead. I think we should check whether merging this is the right approach.

cc @ping-maxwell @himself65

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8564 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 3/12/2026 **Status:** ✅ Merged **Merged:** 3/12/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `2026-03-12/feat/export-adapter-test-suites` --- ### 📝 Commits (1) - [`8e00a92`](https://github.com/better-auth/better-auth/commit/8e00a927d286f63ea68d3c2fb018ef895500f9e6) feat(test-utils): export adapter test suites from '@better-auth/test-utils/adapter' ### 📊 Changes **9 files changed** (+23 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `e2e/adapter/test/adapter-factory/index.ts` (+9 -6) 📝 `packages/test-utils/src/adapter/index.ts` (+1 -0) 📝 `packages/test-utils/src/adapter/suites/auth-flow.ts` (+1 -1) 📝 `packages/test-utils/src/adapter/suites/basic.ts` (+1 -1) ➕ `packages/test-utils/src/adapter/suites/index.ts` (+6 -0) 📝 `packages/test-utils/src/adapter/suites/joins.ts` (+1 -1) 📝 `packages/test-utils/src/adapter/suites/number-id.ts` (+2 -5) 📝 `packages/test-utils/src/adapter/suites/transactions.ts` (+1 -1) 📝 `packages/test-utils/src/adapter/suites/uuid.ts` (+1 -1) </details> ### 📄 Description Related to https://github.com/get-convex/better-auth/pull/292#issuecomment-4041495725 This code was used for our internal e2e tests, so I'm not sure if it's appropriate to export it from the package. While it could be helpful for external users building adapters, it would also make it harder for us to freely change our internal tests and introduce additional maintenance overhead. I think we should check whether merging this is the right approach. cc @ping-maxwell @himself65 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:39:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24964
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?