github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8555] [MERGED] chore: mark third-party peerDependencies as optional in adapter packages #24960

New Issue
Closed
opened 2026-04-15 22:39:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:39:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8555
Author: @himself65
Created: 3/11/2026
Status: ✅ Merged
Merged: 3/11/2026
Merged by: @himself65

Base: canary ← Head: fix/optional-peer-deps

📝 Commits (2)

  • 6827033 fix: mark third-party peerDependencies as optional in adapter packages
  • e1dfff7 chore: add knip ignoreDependencies for optional peer deps in adapter packages

📊 Changes

3 files changed (+22 additions, -0 deletions)

View changed files

📝 knip.jsonc (+12 -0)
📝 packages/kysely-adapter/package.json (+5 -0)
📝 packages/mongo-adapter/package.json (+5 -0)

📄 Description

Summary

  • Mark mongodb as optional peer in @better-auth/mongo-adapter
  • Mark kysely as optional peer in @better-auth/kysely-adapter
  • Mark ioredis as optional peer in @better-auth/redis-storage

These packages are dependencies of the main better-auth package (for re-export paths like better-auth/adapters/mongodb). Without peerDependenciesMeta: { optional: true }, package managers warn about or auto-install mongodb, kysely, and ioredis for all better-auth users, even if they don't use those adapters.

prisma-adapter and drizzle-adapter already had this set correctly.

Test plan

  • Verify pnpm install does not pull in mongodb, kysely, or ioredis unless explicitly installed by the user

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8555 **Author:** [@himself65](https://github.com/himself65) **Created:** 3/11/2026 **Status:** ✅ Merged **Merged:** 3/11/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/optional-peer-deps` --- ### 📝 Commits (2) - [`6827033`](https://github.com/better-auth/better-auth/commit/6827033a4e98f35b003222de548b29b47d095d73) fix: mark third-party peerDependencies as optional in adapter packages - [`e1dfff7`](https://github.com/better-auth/better-auth/commit/e1dfff728d4692baf064e24e68a95d26b5f56fc4) chore: add knip ignoreDependencies for optional peer deps in adapter packages ### 📊 Changes **3 files changed** (+22 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `knip.jsonc` (+12 -0) 📝 `packages/kysely-adapter/package.json` (+5 -0) 📝 `packages/mongo-adapter/package.json` (+5 -0) </details> ### 📄 Description ## Summary - Mark `mongodb` as optional peer in `@better-auth/mongo-adapter` - Mark `kysely` as optional peer in `@better-auth/kysely-adapter` - Mark `ioredis` as optional peer in `@better-auth/redis-storage` These packages are dependencies of the main `better-auth` package (for re-export paths like `better-auth/adapters/mongodb`). Without `peerDependenciesMeta: { optional: true }`, package managers warn about or auto-install `mongodb`, `kysely`, and `ioredis` for all `better-auth` users, even if they don't use those adapters. `prisma-adapter` and `drizzle-adapter` already had this set correctly. ## Test plan - [ ] Verify `pnpm install` does not pull in `mongodb`, `kysely`, or `ioredis` unless explicitly installed by the user --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:39:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24960
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?