github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8524] [MERGED] fix(prisma-adapter): fall back to updateMany for non-unique updates #24937

New Issue
Closed
opened 2026-04-15 22:38:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:38:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8524
Author: @himself65
Created: 3/9/2026
Status: ✅ Merged
Merged: 3/9/2026
Merged by: @himself65

Base: canary ← Head: worktree-fix-prisma-update-8365

📝 Commits (1)

  • f790eb6 fix(prisma-adapter): fall back to updateMany for non-unique updates

📊 Changes

2 files changed (+152 additions, -2 deletions)

View changed files

📝 packages/prisma-adapter/src/prisma-adapter.test.ts (+101 -2)
📝 packages/prisma-adapter/src/prisma-adapter.ts (+51 -0)

📄 Description

Summary

  • Prisma's update() requires a WhereUniqueInput, so updating by non-unique fields like verification.identifier causes a PrismaClientValidationError
  • Detect whether the where clause contains a root-level unique field (id or a field marked unique in the schema)
  • When no unique field is present, use updateMany + findFirst instead of update
  • Keep the existing update path for unique fields like id and unique session tokens

Closes #8365

Test plan

  • Add regression test for non-unique verification identifier updates
  • Add test to ensure unique non-id fields (e.g. session token) still use update
  • Verify existing prisma adapter test still passes
  • pnpm biome check passes on changed files

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8524 **Author:** [@himself65](https://github.com/himself65) **Created:** 3/9/2026 **Status:** ✅ Merged **Merged:** 3/9/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `worktree-fix-prisma-update-8365` --- ### 📝 Commits (1) - [`f790eb6`](https://github.com/better-auth/better-auth/commit/f790eb68827b9ec181d6d1f1f8d98cb828b542bc) fix(prisma-adapter): fall back to updateMany for non-unique updates ### 📊 Changes **2 files changed** (+152 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/prisma-adapter/src/prisma-adapter.test.ts` (+101 -2) 📝 `packages/prisma-adapter/src/prisma-adapter.ts` (+51 -0) </details> ### 📄 Description ## Summary - Prisma's `update()` requires a `WhereUniqueInput`, so updating by non-unique fields like `verification.identifier` causes a `PrismaClientValidationError` - Detect whether the `where` clause contains a root-level unique field (`id` or a field marked `unique` in the schema) - When no unique field is present, use `updateMany` + `findFirst` instead of `update` - Keep the existing `update` path for unique fields like `id` and unique session tokens Closes #8365 ## Test plan - [x] Add regression test for non-unique verification identifier updates - [x] Add test to ensure unique non-id fields (e.g. session token) still use `update` - [x] Verify existing prisma adapter test still passes - [x] `pnpm biome check` passes on changed files --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:38:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24937
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?