github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8483] [MERGED] fix(blog): fix RSS feed link path, image path and blog date #24905

New Issue
Closed
opened 2026-04-15 22:37:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:37:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8483
Author: @0-Sandy
Created: 3/7/2026
Status: ✅ Merged
Merged: 3/9/2026
Merged by: @himself65

Base: canary ← Head: fix-rss

📝 Commits (3)

  • 00f2e8b fix(blog): fix RSS feed link and image path
  • 8ef5b33 style: format code
  • 7b304e5 fix: use the correct blog date in the RSS feed

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 landing/lib/rss.ts (+5 -3)

📄 Description

Some blog URLs already include the full domain, so adding baseUrl again produced invalid links.

For example, in a local environment it could end up like:
http://localhost:3000/https://docs.better-auth.com/...

Now the URL prefix is only added when the URL is relative.

Also fixed the blog date in the RSS feed, instead of using page.data.lastModified, we use page.data.date

Note: In the better auth site, the url is https://better-auth.com/https://docs.better-auth.com/...

Summary by cubic

Fix malformed RSS feed links and images by only adding baseUrl for relative paths, and use the correct post date.

  • Bug Fixes
    • Links and images: prefix baseUrl only when the value starts with "/"; leave absolute URLs unchanged.
    • Date: use page.data.date for RSS items.

Written for commit 7b304e5516. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8483 **Author:** [@0-Sandy](https://github.com/0-Sandy) **Created:** 3/7/2026 **Status:** ✅ Merged **Merged:** 3/9/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix-rss` --- ### 📝 Commits (3) - [`00f2e8b`](https://github.com/better-auth/better-auth/commit/00f2e8b2eed8a9a539ac7a3bbcdb5df64db038fa) fix(blog): fix RSS feed link and image path - [`8ef5b33`](https://github.com/better-auth/better-auth/commit/8ef5b336ca4a4ea96437a839cf87bbee7b61b9bb) style: format code - [`7b304e5`](https://github.com/better-auth/better-auth/commit/7b304e55169d340ee14ebb05e08053c5136031f9) fix: use the correct blog date in the RSS feed ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `landing/lib/rss.ts` (+5 -3) </details> ### 📄 Description Some blog URLs already include the full domain, so adding `baseUrl` again produced invalid links. For example, in a local environment it could end up like: `http://localhost:3000/https://docs.better-auth.com/...` Now the URL prefix is only added when the URL is relative. Also fixed the blog date in the RSS feed, instead of using `page.data.lastModified`, we use `page.data.date` Note: In the better auth site, the url is `https://better-auth.com/https://docs.better-auth.com/...` <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix malformed RSS feed links and images by only adding `baseUrl` for relative paths, and use the correct post date. - **Bug Fixes** - Links and images: prefix `baseUrl` only when the value starts with "/"; leave absolute URLs unchanged. - Date: use `page.data.date` for RSS items. <sup>Written for commit 7b304e55169d340ee14ebb05e08053c5136031f9. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:37:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24905
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?