github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8437] [MERGED] fix(client): preserve stale session data on network or server errors #24873

New Issue
Closed
opened 2026-04-15 22:36:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:36:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8437
Author: @bytaesu
Created: 3/6/2026
Status: ✅ Merged
Merged: 3/6/2026
Merged by: @himself65

Base: canary ← Head: 2026-03-06/fix/preserve-stale-session-on-error

📝 Commits (3)

  • ccbb103 fix(client): preserve stale session data on network or server errors
  • a120bd6 test: mark issue number
  • 8d076c1 Merge branch 'canary' into 2026-03-06/fix/preserve-stale-session-on-error

📊 Changes

2 files changed (+146 additions, -2 deletions)

View changed files

➕ packages/better-auth/src/client/query.test.ts (+141 -0)
📝 packages/better-auth/src/client/query.ts (+5 -2)

📄 Description

Note

Inspired by the stale-while-revalidate pattern (TanStack Query)
https://github.com/TanStack/query/blob/main/packages/query-core/src/query.ts#L650-L664

only clear session data on 401 and preserve stale data on non-401 errors.

Before

https://github.com/user-attachments/assets/3d0a3dc0-6ab8-45d2-b556-01c214012fa2

After

https://github.com/user-attachments/assets/39da7b3a-5495-4cc6-b111-79c1ad1ff1d1

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8437 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 3/6/2026 **Status:** ✅ Merged **Merged:** 3/6/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `2026-03-06/fix/preserve-stale-session-on-error` --- ### 📝 Commits (3) - [`ccbb103`](https://github.com/better-auth/better-auth/commit/ccbb1034102e4892f2d7505c98ee983f168ae188) fix(client): preserve stale session data on network or server errors - [`a120bd6`](https://github.com/better-auth/better-auth/commit/a120bd6c968e2f12af121c14d38345e7faebff15) test: mark issue number - [`8d076c1`](https://github.com/better-auth/better-auth/commit/8d076c176a8919f912bc4014bc02f55764a25fee) Merge branch 'canary' into 2026-03-06/fix/preserve-stale-session-on-error ### 📊 Changes **2 files changed** (+146 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `packages/better-auth/src/client/query.test.ts` (+141 -0) 📝 `packages/better-auth/src/client/query.ts` (+5 -2) </details> ### 📄 Description > [!NOTE] > Inspired by the stale-while-revalidate pattern (TanStack Query) > https://github.com/TanStack/query/blob/main/packages/query-core/src/query.ts#L650-L664 only clear session data on 401 and preserve stale data on non-401 errors. - Closes #8420 --- ### Before https://github.com/user-attachments/assets/3d0a3dc0-6ab8-45d2-b556-01c214012fa2 ### After https://github.com/user-attachments/assets/39da7b3a-5495-4cc6-b111-79c1ad1ff1d1 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:36:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24873
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?