github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8369] [MERGED] fix(sso): handle bare domains in domain verification #24826

New Issue
Closed
opened 2026-04-15 22:34:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:34:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8369
Author: @himself65
Created: 3/4/2026
Status: ✅ Merged
Merged: 3/6/2026
Merged by: @himself65

Base: canary ← Head: fix/sso-bare-domain-verification

📝 Commits (2)

  • a6eb409 fix(sso): handle bare domains in domain verification (#8361)
  • b9883c7 chore: add tldts to cspell dictionary

📊 Changes

7 files changed (+111 additions, -2 deletions)

View changed files

📝 .cspell/third-party.txt (+1 -0)
📝 packages/sso/package.json (+1 -0)
📝 packages/sso/src/domain-verification.test.ts (+47 -0)
📝 packages/sso/src/routes/domain-verification.ts (+9 -1)
📝 packages/sso/src/utils.test.ts (+32 -1)
📝 packages/sso/src/utils.ts (+5 -0)
📝 pnpm-lock.yaml (+16 -0)

📄 Description

Summary

  • Fixes #8361: new URL(provider.domain).hostname throws ERR_INVALID_URL when provider.domain is a bare domain like "github.com" (no protocol)
  • Adds a getHostnameFromDomain() utility using tldts that handles both bare domains and full URLs
  • Adds explicit BAD_REQUEST error for invalid domains instead of silently swallowing the error in the DNS try/catch

Test plan

  • Added unit tests for getHostnameFromDomain (bare domain, full URL, URL with port, subdomain, URL with path, empty string)
  • Added integration test verifying domain ownership with a bare domain ("hello.com")
  • All 40 existing + new tests pass

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8369 **Author:** [@himself65](https://github.com/himself65) **Created:** 3/4/2026 **Status:** ✅ Merged **Merged:** 3/6/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/sso-bare-domain-verification` --- ### 📝 Commits (2) - [`a6eb409`](https://github.com/better-auth/better-auth/commit/a6eb409340d5b1c6b2ab13bd70a0a2dfa127ffd7) fix(sso): handle bare domains in domain verification (#8361) - [`b9883c7`](https://github.com/better-auth/better-auth/commit/b9883c7549feef0305a6b99fbf5f5d54d283459f) chore: add tldts to cspell dictionary ### 📊 Changes **7 files changed** (+111 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.cspell/third-party.txt` (+1 -0) 📝 `packages/sso/package.json` (+1 -0) 📝 `packages/sso/src/domain-verification.test.ts` (+47 -0) 📝 `packages/sso/src/routes/domain-verification.ts` (+9 -1) 📝 `packages/sso/src/utils.test.ts` (+32 -1) 📝 `packages/sso/src/utils.ts` (+5 -0) 📝 `pnpm-lock.yaml` (+16 -0) </details> ### 📄 Description ## Summary - Fixes #8361: `new URL(provider.domain).hostname` throws `ERR_INVALID_URL` when `provider.domain` is a bare domain like `"github.com"` (no protocol) - Adds a `getHostnameFromDomain()` utility using `tldts` that handles both bare domains and full URLs - Adds explicit `BAD_REQUEST` error for invalid domains instead of silently swallowing the error in the DNS try/catch ## Test plan - [x] Added unit tests for `getHostnameFromDomain` (bare domain, full URL, URL with port, subdomain, URL with path, empty string) - [x] Added integration test verifying domain ownership with a bare domain (`"hello.com"`) - [x] All 40 existing + new tests pass --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:34:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24826
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?