github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8311] [CLOSED] Pr 8133 ci failure #24789

New Issue
Closed
opened 2026-04-15 22:33:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:33:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8311
Author: @himself65
Created: 3/3/2026
Status: ❌ Closed

Base: canary ← Head: cursor/pr-8133-ci-failure-ddd3

📝 Commits (1)

  • 1804612 fix(cookies): decode percent-encoded values in parseSetCookieHeader to prevent double-encoding

📊 Changes

7 files changed (+52 additions, -5 deletions)

View changed files

📝 packages/better-auth/src/cookies/cookie-utils.ts (+10 -1)
📝 packages/better-auth/src/cookies/cookies.test.ts (+6 -0)
📝 packages/better-auth/src/integrations/next-js.ts (+1 -1)
📝 packages/better-auth/src/integrations/svelte-kit.ts (+1 -1)
📝 packages/better-auth/src/integrations/tanstack-start-solid.ts (+1 -1)
📝 packages/better-auth/src/integrations/tanstack-start.ts (+1 -1)
📝 packages/better-auth/src/plugins/custom-session/custom-session.test.ts (+32 -0)

📄 Description

Rebase PR #8133 onto current canary and fix cookie decoding issues.

The original CI failures were pre-existing on an older canary commit and unrelated to the PR's changes. This PR re-applies the changes from #8133, centralizes URI decoding of cookie values in parseSetCookieHeader, removes redundant decodeURIComponent calls in integrations, and adds tests to prevent double-encoding of session tokens.

Slack Thread

Open in Web Open in Cursor 

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8311 **Author:** [@himself65](https://github.com/himself65) **Created:** 3/3/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `cursor/pr-8133-ci-failure-ddd3` --- ### 📝 Commits (1) - [`1804612`](https://github.com/better-auth/better-auth/commit/18046126d21fdc074b66f9bd32fc3f78742ac1ae) fix(cookies): decode percent-encoded values in parseSetCookieHeader to prevent double-encoding ### 📊 Changes **7 files changed** (+52 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/cookies/cookie-utils.ts` (+10 -1) 📝 `packages/better-auth/src/cookies/cookies.test.ts` (+6 -0) 📝 `packages/better-auth/src/integrations/next-js.ts` (+1 -1) 📝 `packages/better-auth/src/integrations/svelte-kit.ts` (+1 -1) 📝 `packages/better-auth/src/integrations/tanstack-start-solid.ts` (+1 -1) 📝 `packages/better-auth/src/integrations/tanstack-start.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/custom-session/custom-session.test.ts` (+32 -0) </details> ### 📄 Description <!-- CURSOR_AGENT_PR_BODY_BEGIN --> Rebase PR #8133 onto current canary and fix cookie decoding issues. The original CI failures were pre-existing on an older canary commit and unrelated to the PR's changes. This PR re-applies the changes from #8133, centralizes URI decoding of cookie values in `parseSetCookieHeader`, removes redundant `decodeURIComponent` calls in integrations, and adds tests to prevent double-encoding of session tokens. --- [Slack Thread](https://betterauth.slack.com/archives/C0A8B5BARUK/p1772507531311089?thread_ts=1772507531.311089&cid=C0A8B5BARUK) <p><a href="https://cursor.com/agents/bc-1585a5a2-51fb-513b-bc0a-92ba88f2d1d5"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/background-agent?bcId=bc-1585a5a2-51fb-513b-bc0a-92ba88f2d1d5"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</p> <!-- CURSOR_AGENT_PR_BODY_END --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:33:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24789
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?