github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8242] [CLOSED] fix(db): support verification CRUD operations with secondary storage #24747

New Issue
Closed
opened 2026-04-15 22:32:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:32:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8242
Author: @himself65
Created: 3/1/2026
Status: ❌ Closed

Base: canary ← Head: fix/magic-link-secondary-storage

📝 Commits (1)

  • 7381426 fix(db): support verification CRUD operations with secondary storage (#8228)

📊 Changes

2 files changed (+240 additions, -5 deletions)

View changed files

📝 packages/better-auth/src/db/internal-adapter.ts (+65 -5)
📝 packages/better-auth/src/plugins/magic-link/magic-link.test.ts (+175 -0)

📄 Description

When secondaryStorage is enabled without verification.storeInDatabase, updateVerificationValue and deleteVerificationValue would fail with "Model verification not found in schema" because they always tried to hit the database directly.

Fixes: https://github.com/better-auth/better-auth/issues/8228

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8242 **Author:** [@himself65](https://github.com/himself65) **Created:** 3/1/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `fix/magic-link-secondary-storage` --- ### 📝 Commits (1) - [`7381426`](https://github.com/better-auth/better-auth/commit/738142673f0cf25961d7d3a8a9433ac1a0c415c5) fix(db): support verification CRUD operations with secondary storage (#8228) ### 📊 Changes **2 files changed** (+240 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/db/internal-adapter.ts` (+65 -5) 📝 `packages/better-auth/src/plugins/magic-link/magic-link.test.ts` (+175 -0) </details> ### 📄 Description When secondaryStorage is enabled without verification.storeInDatabase, updateVerificationValue and deleteVerificationValue would fail with "Model verification not found in schema" because they always tried to hit the database directly. Fixes: https://github.com/better-auth/better-auth/issues/8228 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:32:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24747
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?