github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8158] [MERGED] fix: remove max validation on siwe verify endpoint #24686

New Issue
Closed
opened 2026-04-15 22:30:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:30:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8158
Author: @orshih6
Created: 2/26/2026
Status: ✅ Merged
Merged: 2/26/2026
Merged by: @himself65

Base: canary ← Head: fix/siwe-remove-max-validation-on-siwe-endpoint

📝 Commits (2)

  • a835905 remove max validation on siwe verify endpoint
  • 78e6bbb fix: format chainId zod chain to single line

📊 Changes

1 file changed (+1 additions, -7 deletions)

View changed files

📝 packages/better-auth/src/plugins/siwe/index.ts (+1 -7)

📄 Description

I forgot to remove the validation on the SIWE verify endpoint. The error occurs because I’m using the beta version (1.5.0-beta.19).

Screenshot 2026-02-26 at 13 45 43

Summary by cubic

Removed the max(2147483647) constraint from the SIWE verify endpoint schema to prevent validation errors on v1.5.0-beta.19 and allow valid requests to pass. Also simplified the chainId zod schema formatting.

Written for commit 78e6bbbb94. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8158 **Author:** [@orshih6](https://github.com/orshih6) **Created:** 2/26/2026 **Status:** ✅ Merged **Merged:** 2/26/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/siwe-remove-max-validation-on-siwe-endpoint` --- ### 📝 Commits (2) - [`a835905`](https://github.com/better-auth/better-auth/commit/a835905f60a7f9354f0e2087118fa7a1fd2c8b6a) remove max validation on siwe verify endpoint - [`78e6bbb`](https://github.com/better-auth/better-auth/commit/78e6bbbb9433cf7a6ef3e34591079c55f7f9e4e5) fix: format chainId zod chain to single line ### 📊 Changes **1 file changed** (+1 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/siwe/index.ts` (+1 -7) </details> ### 📄 Description I forgot to remove the validation on the SIWE verify endpoint. The error occurs because I’m using the beta version (1.5.0-beta.19). <img width="907" height="715" alt="Screenshot 2026-02-26 at 13 45 43" src="https://github.com/user-attachments/assets/d4935d27-5664-4375-91d6-21215b22e9e4" /> <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Removed the max(2147483647) constraint from the SIWE verify endpoint schema to prevent validation errors on v1.5.0-beta.19 and allow valid requests to pass. Also simplified the chainId zod schema formatting. <sup>Written for commit 78e6bbbb9433cf7a6ef3e34591079c55f7f9e4e5. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:30:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24686
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?