github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8006] [MERGED] fix(rate-limit): harden default rules and fix phone-number window #24582

New Issue
Closed
opened 2026-04-15 22:26:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:26:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8006
Author: @Paola3stefania
Created: 2/16/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @Bekacru

Base: canary ← Head: fix/rate-limit-email-flooding-and-ip-warning

📝 Commits (2)

  • d3a7c6f rate limit fix and phoen number window
  • a10c253 Merge branch 'canary' into fix/rate-limit-email-flooding-and-ip-warning

📊 Changes

2 files changed (+23 additions, -1 deletions)

View changed files

📝 packages/better-auth/src/api/rate-limiter/index.ts (+22 -0)
📝 packages/better-auth/src/plugins/phone-number/index.ts (+1 -1)

📄 Description

Summary by cubic

Strengthened rate-limit rules for email verification and password reset endpoints to reduce email flooding. Fixed the phone-number plugin to use seconds for its window and added a one-time IP-missing warning to avoid log spam and guide proxy setup.

  • New Features

    • Special rules (window: 60s, max: 3) for: /request-password-reset, /send-verification-email, /forget-password..., /email-otp/send-verification-otp, /email-otp/request-password-reset.

  • Bug Fixes

    • Phone-number plugin: window corrected to 60 seconds (was 60*1000).
    • Log a single warning when client IP is unavailable, with guidance to configure trustedProxies.

Written for commit a10c25303e. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8006 **Author:** [@Paola3stefania](https://github.com/Paola3stefania) **Created:** 2/16/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `fix/rate-limit-email-flooding-and-ip-warning` --- ### 📝 Commits (2) - [`d3a7c6f`](https://github.com/better-auth/better-auth/commit/d3a7c6fd82390ea37140908fd9942a6ecffaf5e7) rate limit fix and phoen number window - [`a10c253`](https://github.com/better-auth/better-auth/commit/a10c25303e6c8dbbe083ccf5ad8d993402c81647) Merge branch 'canary' into fix/rate-limit-email-flooding-and-ip-warning ### 📊 Changes **2 files changed** (+23 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/api/rate-limiter/index.ts` (+22 -0) 📝 `packages/better-auth/src/plugins/phone-number/index.ts` (+1 -1) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Strengthened rate-limit rules for email verification and password reset endpoints to reduce email flooding. Fixed the phone-number plugin to use seconds for its window and added a one-time IP-missing warning to avoid log spam and guide proxy setup. - **New Features** - Special rules (window: 60s, max: 3) for: /request-password-reset, /send-verification-email, /forget-password..., /email-otp/send-verification-otp, /email-otp/request-password-reset. - **Bug Fixes** - Phone-number plugin: window corrected to 60 seconds (was 60*1000). - Log a single warning when client IP is unavailable, with guidance to configure trustedProxies. <sup>Written for commit a10c25303e6c8dbbe083ccf5ad8d993402c81647. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:26:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24582
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?