github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7903] [MERGED] fix(sso): use POST with body params for provider CRUD endpoints to fix client inference #24524

New Issue
Closed
opened 2026-04-15 22:24:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:24:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7903
Author: @Paola3stefania
Created: 2/11/2026
Status: ✅ Merged
Merged: 2/11/2026
Merged by: @himself65

Base: canary ← Head: fix/sso-client-inference-endpoints

📝 Commits (2)

📊 Changes

3 files changed (+56 additions, -60 deletions)

View changed files

📝 packages/sso/src/client.ts (+1 -1)
📝 packages/sso/src/providers.test.ts (+39 -45)
📝 packages/sso/src/routes/providers.ts (+16 -14)

📄 Description

Summary by cubic

Switched SSO provider CRUD endpoints to use POST with body params and moved the read endpoint to /sso/get-provider with providerId in query to fix client type inference and request building.

  • Bug Fixes

    • Changed PATCH /sso/providers/:providerId to POST /sso/update-provider (providerId in body).
    • Changed DELETE /sso/providers/:providerId to POST /sso/delete-provider (providerId in body).
    • Moved GET /sso/providers/:providerId to GET /sso/get-provider (providerId in query).
    • Updated client pathMethods, validation schemas, and tests to match.

  • Migration

    • Use auth.api.getSSOProvider({ query: { providerId } }).
    • Use auth.api.updateSSOProvider({ body: { providerId, ...fields } }).
    • Use auth.api.deleteSSOProvider({ body: { providerId } }).
    • Stop using path params and PATCH/DELETE for provider operations.

Written for commit c733c1d048. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7903 **Author:** [@Paola3stefania](https://github.com/Paola3stefania) **Created:** 2/11/2026 **Status:** ✅ Merged **Merged:** 2/11/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/sso-client-inference-endpoints` --- ### 📝 Commits (2) - [`0972fdf`](https://github.com/better-auth/better-auth/commit/0972fdf5fa98a62c153a930939845387d0ee2e17) fix: ednppoints - [`c733c1d`](https://github.com/better-auth/better-auth/commit/c733c1d0485610656eef009fbccfde6c38e47c59) make lint happy ### 📊 Changes **3 files changed** (+56 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `packages/sso/src/client.ts` (+1 -1) 📝 `packages/sso/src/providers.test.ts` (+39 -45) 📝 `packages/sso/src/routes/providers.ts` (+16 -14) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Switched SSO provider CRUD endpoints to use POST with body params and moved the read endpoint to /sso/get-provider with providerId in query to fix client type inference and request building. - **Bug Fixes** - Changed PATCH /sso/providers/:providerId to POST /sso/update-provider (providerId in body). - Changed DELETE /sso/providers/:providerId to POST /sso/delete-provider (providerId in body). - Moved GET /sso/providers/:providerId to GET /sso/get-provider (providerId in query). - Updated client pathMethods, validation schemas, and tests to match. - **Migration** - Use auth.api.getSSOProvider({ query: { providerId } }). - Use auth.api.updateSSOProvider({ body: { providerId, ...fields } }). - Use auth.api.deleteSSOProvider({ body: { providerId } }). - Stop using path params and PATCH/DELETE for provider operations. <sup>Written for commit c733c1d0485610656eef009fbccfde6c38e47c59. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:24:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24524
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?