github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7808] [MERGED] chore(scim): fix empty IN queries in user list endpoint #24465

New Issue
Closed
opened 2026-04-15 22:23:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:23:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7808
Author: @jonathansamines
Created: 2/5/2026
Status: ✅ Merged
Merged: 2/5/2026
Merged by: @himself65

Base: canary ← Head: chore/fix-scim-empty-members-query

📝 Commits (3)

  • 7b284bc chore(scim): add failing test for empty in query
  • 3fa917d chore(scim): fix empty IN queries
  • 7d234de chore(scim): fix linting

📊 Changes

2 files changed (+129 additions, -0 deletions)

View changed files

📝 packages/scim/src/routes.ts (+22 -0)
📝 packages/scim/src/scim.test.ts (+107 -0)

📄 Description

Summary by cubic

Fixes the SCIM /Users list to return a proper empty ListResponse when a provider or organization has no users, avoiding empty IN queries and preventing errors.

  • Bug Fixes
    • Return an empty SCIM ListResponse when accountUserIds or memberUserIds is empty.
    • Avoid DB queries with IN [] on user ID filters.
    • Added tests to confirm empty list behavior for providers and organizations (Postgres).

Written for commit 7d234de40b. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7808 **Author:** [@jonathansamines](https://github.com/jonathansamines) **Created:** 2/5/2026 **Status:** ✅ Merged **Merged:** 2/5/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `chore/fix-scim-empty-members-query` --- ### 📝 Commits (3) - [`7b284bc`](https://github.com/better-auth/better-auth/commit/7b284bc34310931685516917e3e2242510ed08bf) chore(scim): add failing test for empty in query - [`3fa917d`](https://github.com/better-auth/better-auth/commit/3fa917d5b06deef0d0e7d52b67c8b7932bbd598b) chore(scim): fix empty IN queries - [`7d234de`](https://github.com/better-auth/better-auth/commit/7d234de40bf8a1c3752b9a0557c7629b62da06e5) chore(scim): fix linting ### 📊 Changes **2 files changed** (+129 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/scim/src/routes.ts` (+22 -0) 📝 `packages/scim/src/scim.test.ts` (+107 -0) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Fixes the SCIM /Users list to return a proper empty ListResponse when a provider or organization has no users, avoiding empty IN queries and preventing errors. - **Bug Fixes** - Return an empty SCIM ListResponse when accountUserIds or memberUserIds is empty. - Avoid DB queries with IN [] on user ID filters. - Added tests to confirm empty list behavior for providers and organizations (Postgres). <sup>Written for commit 7d234de40bf8a1c3752b9a0557c7629b62da06e5. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:23:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24465
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?