github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7716] [CLOSED] fix(oauth-provider): detect fetch requests using sec-fetch-mode header #24411

New Issue
Closed
opened 2026-04-15 22:21:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:21:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7716
Author: @bytaesu
Created: 1/31/2026
Status: ❌ Closed

Base: main ← Head: 2026-01-31/fix/oauth-provider-redirect

📝 Commits (2)

  • 3c9d21c fix: detect fetch requests using sec-fetch-mode header
  • 08e3573 test: add cases for handleRedirect

📊 Changes

2 files changed (+131 additions, -3 deletions)

View changed files

📝 packages/oauth-provider/src/authorize.test.ts (+127 -0)
📝 packages/oauth-provider/src/authorize.ts (+4 -3)

📄 Description

Note

Reference: https://github.com/better-auth/better-auth/blob/canary/packages/better-auth/src/plugins/oidc-provider/authorize.ts#L31

Summary by cubic

Detects fetch-based OAuth authorize requests using the sec-fetch-mode header and returns a JSON redirect payload, while keeping 302 redirects for normal navigation. This makes SPA/fetch clients handle redirects cleanly.

  • Bug Fixes
    • handleRedirect returns JSON when sec-fetch-mode=cors or Accept: application/json is present.
    • Falls back to 302 redirect when no fetch headers are set.
    • Added tests covering both JSON and 302 behaviors.

Written for commit 08e3573b6c. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7716 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 1/31/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `2026-01-31/fix/oauth-provider-redirect` --- ### 📝 Commits (2) - [`3c9d21c`](https://github.com/better-auth/better-auth/commit/3c9d21c1c1c06cf11a766105291e9f2e8725b5d2) fix: detect fetch requests using sec-fetch-mode header - [`08e3573`](https://github.com/better-auth/better-auth/commit/08e3573b6cd771d63c4360bba3f437ea3fb92539) test: add cases for handleRedirect ### 📊 Changes **2 files changed** (+131 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/oauth-provider/src/authorize.test.ts` (+127 -0) 📝 `packages/oauth-provider/src/authorize.ts` (+4 -3) </details> ### 📄 Description > [!NOTE] > Reference: https://github.com/better-auth/better-auth/blob/canary/packages/better-auth/src/plugins/oidc-provider/authorize.ts#L31 - Closes https://github.com/better-auth/better-auth/issues/7710 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Detects fetch-based OAuth authorize requests using the sec-fetch-mode header and returns a JSON redirect payload, while keeping 302 redirects for normal navigation. This makes SPA/fetch clients handle redirects cleanly. - **Bug Fixes** - handleRedirect returns JSON when sec-fetch-mode=cors or Accept: application/json is present. - Falls back to 302 redirect when no fetch headers are set. - Added tests covering both JSON and 302 behaviors. <sup>Written for commit 08e3573b6cd771d63c4360bba3f437ea3fb92539. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:21:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24411
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?