github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7698] [CLOSED] fix(phone-number): remove phone number fallback for getTempName #24399

New Issue
Closed
opened 2026-04-15 22:21:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-15 22:21:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7698
Author: @bytaesu
Created: 1/30/2026
Status: ❌ Closed

Base: canary ← Head: cursor/gettempname-phone-fallback-28d4

📝 Commits (7)

  • f38da41 chore: should keep singleton of ctx (#7654)
  • e90d092 fix(phone-number): remove phone number fallback in getTempName
  • b507316 Merge branch 'canary' into cursor/gettempname-phone-fallback-28d4
  • d8b8414 Merge branch 'canary' into cursor/gettempname-phone-fallback-28d4
  • 4ec1cfb fix: type
  • 8c2335c docs: comment format
  • 263748e Merge branch 'canary' into cursor/gettempname-phone-fallback-28d4

📊 Changes

3 files changed (+5 additions, -7 deletions)

View changed files

📝 docs/content/docs/plugins/phone-number.mdx (+2 -2)
📝 packages/better-auth/src/plugins/phone-number/routes.ts (+3 -3)
📝 packages/better-auth/src/plugins/phone-number/types.ts (+0 -2)

📄 Description

This pull request contains changes generated by a Cursor Cloud Agent

Open in Cursor Open in Web

Summary by cubic

Remove the phone-number plugin’s fallback that used the phone number as a temporary name. If getTempName isn’t provided, no name is set; aligns with name being optional.

  • Bug Fixes

    • Removed fallback in verifyPhoneNumber; name is only set via getTempName.
    • Cleaned up docs and types to remove outdated default-name references.

  • Migration

    • If you relied on using the phone number as the name, implement signUpOnVerification.getTempName(phoneNumber) to keep that behavior.

Written for commit 263748e687. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7698 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 1/30/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `cursor/gettempname-phone-fallback-28d4` --- ### 📝 Commits (7) - [`f38da41`](https://github.com/better-auth/better-auth/commit/f38da41c117e0858e16a64223337a399904e3eab) chore: should keep singleton of ctx (#7654) - [`e90d092`](https://github.com/better-auth/better-auth/commit/e90d092444230e6b0fabfecbdf7f1d0340a8cdf1) fix(phone-number): remove phone number fallback in getTempName - [`b507316`](https://github.com/better-auth/better-auth/commit/b5073165753ddfcdaa44bbf7479d30e371da23a0) Merge branch 'canary' into cursor/gettempname-phone-fallback-28d4 - [`d8b8414`](https://github.com/better-auth/better-auth/commit/d8b84144fde553618aa453d7a11974e56f4dc049) Merge branch 'canary' into cursor/gettempname-phone-fallback-28d4 - [`4ec1cfb`](https://github.com/better-auth/better-auth/commit/4ec1cfb81507737205dae165e2ad0a173af49f68) fix: type - [`8c2335c`](https://github.com/better-auth/better-auth/commit/8c2335c74d0bed93fd92eea5110c681b58ce3917) docs: comment format - [`263748e`](https://github.com/better-auth/better-auth/commit/263748e687ebc3a87eb086e573e9c152ac070e4a) Merge branch 'canary' into cursor/gettempname-phone-fallback-28d4 ### 📊 Changes **3 files changed** (+5 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/plugins/phone-number.mdx` (+2 -2) 📝 `packages/better-auth/src/plugins/phone-number/routes.ts` (+3 -3) 📝 `packages/better-auth/src/plugins/phone-number/types.ts` (+0 -2) </details> ### 📄 Description This pull request contains changes generated by a Cursor Cloud Agent <a href="https://cursor.com/background-agent?bcId=bc-b4808d5a-bbb5-4b9e-af47-c3d46f46478d"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-b4808d5a-bbb5-4b9e-af47-c3d46f46478d"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Remove the phone-number plugin’s fallback that used the phone number as a temporary name. If getTempName isn’t provided, no name is set; aligns with name being optional. - **Bug Fixes** - Removed fallback in verifyPhoneNumber; name is only set via getTempName. - Cleaned up docs and types to remove outdated default-name references. - **Migration** - If you relied on using the phone number as the name, implement signUpOnVerification.getTempName(phoneNumber) to keep that behavior. <sup>Written for commit 263748e687ebc3a87eb086e573e9c152ac070e4a. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-15 22:21:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#24399
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?